fix: Field should have block layout, not inline #25126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bfa0b93:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: a8e81b5296f1551e74010c1d2ad9d37c6fd48306 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1304 | 1346 | 5000 | |
| Button | mount | 951 | 965 | 5000 | |
| FluentProvider | mount | 1604 | 1584 | 5000 | |
| FluentProviderWithTheme | mount | 632 | 633 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 592 | 595 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 626 | 635 | 10 | |
| MakeStyles | mount | 1912 | 1919 | 50000 | |
| SpinButton | mount | 2513 | 2539 | 5000 |
khmakoto
approved these changes
Oct 7, 2022
spmonahan
approved these changes
Oct 10, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 11, 2022
* master: fix: Menu trigger should be focused when menu is closed with keyboard (microsoft#25165) fix(codemods): Do not fail on empty configMod config (microsoft#25148) fix: Field should have block layout, not inline (microsoft#25126) chore: Update Griffel to latest version (microsoft#25075)
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* Change Field to use `grid` for its layout, and update several stories to also use `grid`. * Change the `validationMessage` and `hint` slots to be `<div>` elements instead of `<span>`, since they are blocks within the field layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Field uses
inline-gridfor its layout, but fields are never meant to be inline, and should default to being full-width of their parent container.New Behavior
Change Field to use
gridfor its layout, and update several stories to also usegrid.Bonus fix: change the
validationMessageandhintslots to be<div>elements instead of<span>, since they are blocks within the field layout.Related Issue(s)