Skip to content

chore(vr-tests-v9): Convert Button VR tests to CSF #25108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TristanWatanabe merged 59 commits into from
Nov 2, 2022
Merged

chore(vr-tests-v9): Convert Button VR tests to CSF #25108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
fd8c495
add utility functions for CSF test creation
TristanWatanabe Oct 2, 2022
68f2c3c
chore: convert Button stories to CSF
TristanWatanabe Oct 2, 2022
a0723ca
chore: convert CompoundButton to CSF
TristanWatanabe Oct 2, 2022
488e548
fix: add fluentprovider decorator to all CSF stories
TristanWatanabe Oct 2, 2022
96be209
chore: convert ToggleButton to CSF
TristanWatanabe Oct 2, 2022
ddf6b0b
fix: update getStoryVariant to fallback to story.name
TristanWatanabe Oct 2, 2022
232688a
chore: convert MenuButton to CSF
TristanWatanabe Oct 2, 2022
c8c311e
fix: add space to story.name fallback in getStoryVariant
TristanWatanabe Oct 2, 2022
45f614f
test: uncomment out hover snapshot for CompoundButtonDefault
TristanWatanabe Oct 2, 2022
83bd1ab
test: try to fix flaky hover tests
TristanWatanabe Oct 2, 2022
0157f8f
implement withFluentVRTestVariants decorator
TristanWatanabe Oct 8, 2022
d00208f
update test to include new decorator
TristanWatanabe Oct 8, 2022
c797198
update typings
TristanWatanabe Oct 10, 2022
bda9ea4
fix: typing and update API
TristanWatanabe Oct 10, 2022
dcfcde3
Add usage of decorator to README
TristanWatanabe Oct 10, 2022
794bd7f
remove unneed peerDep
TristanWatanabe Oct 10, 2022
f306846
fix: typing
TristanWatanabe Oct 10, 2022
fb87708
Update API
TristanWatanabe Oct 10, 2022
7bf1873
revert additions to react-storybook package
TristanWatanabe Oct 12, 2022
ed168ee
delete withFluentVrTestVariants
TristanWatanabe Oct 12, 2022
d3765ac
remove withFluentVrTestVariant
TristanWatanabe Oct 12, 2022
1f26987
feat: withFluentProvider now accepts fluentTheme and dir
TristanWatanabe Oct 12, 2022
66c95ef
Add exported theme constants
TristanWatanabe Oct 12, 2022
ab22cd5
feat: add isVrTest parameter
TristanWatanabe Oct 13, 2022
060d696
Revert "Add usage of decorator to README"
TristanWatanabe Oct 13, 2022
18c3e6d
update ReadMe
TristanWatanabe Oct 13, 2022
14847d9
Add constants and FluentParameters to exports
TristanWatanabe Oct 13, 2022
20091d7
Update API
TristanWatanabe Oct 13, 2022
e840ba7
Revert "Update API"
TristanWatanabe Oct 13, 2022
21eba2e
Revert "fix: typing and update API"
TristanWatanabe Oct 13, 2022
81de523
feedback: don't export constants, export FluentParameter type
TristanWatanabe Oct 16, 2022
b5f3788
feedback: replace isVrTest param with more dynamic mode param
TristanWatanabe Oct 16, 2022
4842eb9
feedback: add parameters identity function and export
TristanWatanabe Oct 16, 2022
8317329
Update API
TristanWatanabe Oct 16, 2022
55836b6
Update README
TristanWatanabe Oct 16, 2022
1559515
Merge branch 'master' into add-VrTestVariants-decorator
TristanWatanabe Oct 16, 2022
90f267b
Merge branch 'add-VrTestVariants-decorator' into button-convert-to-csf
TristanWatanabe Oct 16, 2022
d1b213d
refactor: use withFluentProvider addon instead and configure paramete…
TristanWatanabe Oct 16, 2022
6c6550a
add react-storybook-addon and update github workflow
TristanWatanabe Oct 16, 2022
139aed9
fix: build react-storybook-addon in screener CI
TristanWatanabe Oct 16, 2022
6cf51af
test: remove loadworkspaceaddon
TristanWatanabe Oct 16, 2022
c0616d0
feat: add utils file to host reused stuff in various Button stories
TristanWatanabe Oct 16, 2022
cd7b01d
refactor: add generalized withScreenerSteps decorator
TristanWatanabe Oct 16, 2022
4488610
uncomment out flaky test
TristanWatanabe Oct 16, 2022
d388c0f
Add missing AsAnAnchor test
TristanWatanabe Oct 16, 2022
d888f92
remove unintended prettier changes
TristanWatanabe Oct 20, 2022
b86dfd7
Merge branch 'add-VrTestVariants-decorator' into button-convert-to-csf
TristanWatanabe Oct 16, 2022
2ad10e8
Merge branch 'master' into button-convert-to-csf
TristanWatanabe Oct 22, 2022
076eec0
pin storybook-addon and use Parameters from @storybook/addons
TristanWatanabe Nov 1, 2022
ca1114a
nit: break up getStoryVariant to different functions
TristanWatanabe Nov 1, 2022
76a9f99
fix: getStoryName function now works as expected
TristanWatanabe Nov 1, 2022
4351789
feat: jest tests now run in package
TristanWatanabe Nov 1, 2022
b469b71
test: add tests for getStoryVariant
TristanWatanabe Nov 1, 2022
a4864ac
Merge branch 'master' into button-convert-to-csf
TristanWatanabe Nov 1, 2022
5d7527f
fix: make fluent storybook-addon a caret dep again to fix syncpack error
TristanWatanabe Nov 1, 2022
e2ba1f0
fix(react-storybook-addon): update API
TristanWatanabe Nov 2, 2022
3d6983d
nit: generalize extra screener-build step for v9
TristanWatanabe Nov 2, 2022
339ce77
Merge branch 'master' into button-convert-to-csf
TristanWatanabe Nov 2, 2022
781e403
test: add test for story naming
TristanWatanabe Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/screener-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,10 @@ jobs:
printenv | sort ;\
echo "SHELLOPTS $SHELLOPTS" ;\

- name: build vr-tests-react-components storybook
run: yarn lage build --to @fluentui/vr-tests-react-components
if: ${{env.SKIP_SCREENER_BUILD == 'false'}}

- name: build vr-tests-react-components storybook
run: yarn workspace @fluentui/vr-tests-react-components screener:build
if: ${{env.SKIP_SCREENER_BUILD == 'false'}}
Expand Down
2 changes: 2 additions & 0 deletions apps/vr-tests-react-components/.storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ const path = require('path');
const { TsconfigPathsPlugin } = require('tsconfig-paths-webpack-plugin');

module.exports = /** @type {import('../../../.storybook/main').StorybookBaseConfig} */ ({
addons: ['@fluentui/react-storybook-addon'],

stories: ['../src/**/*.stories.tsx'],
core: {
builder: 'webpack5',
Expand Down
3 changes: 2 additions & 1 deletion apps/vr-tests-react-components/.storybook/preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ setAddon({
},
});

export const parameters = { layout: 'none' };
/** @type {import("@fluentui/react-storybook-addon").FluentParameters} */
export const parameters = { layout: 'none', mode: 'vr-test' };

// For static storybook per https://github.com/screener-io/screener-storybook#testing-with-static-storybook-app
if (typeof window === 'object') {
Expand Down
18 changes: 18 additions & 0 deletions apps/vr-tests-react-components/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// @ts-check

/**
* @type {import('@jest/types').Config.InitialOptions}
*/
module.exports = {
displayName: 'vr-tests-react-components',
preset: '../../jest.preset.js',
globals: {
'ts-jest': {
tsConfig: '<rootDir>/tsconfig.json',
diagnostics: false,
},
},
transform: {
'^.+\\.tsx?$': 'ts-jest',
},
};
3 changes: 3 additions & 0 deletions apps/vr-tests-react-components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@
"screener": "just-scripts screener",
"screener:build": "yarn build",
"start": "start-storybook",
"test": "just-scripts test",
"type-check": "tsc"
},
"devDependencies": {
"@fluentui/eslint-plugin": "*",
"@fluentui/scripts": "^1.0.0",
"storywright": "0.0.23-beta.6"
},
"dependencies": {
Expand Down Expand Up @@ -46,6 +48,7 @@
"@fluentui/react-slider": "^9.0.9",
"@fluentui/react-spinner": "^9.0.9",
"@fluentui/react-spinbutton": "^9.0.7",
"@fluentui/react-storybook-addon": "^9.0.0-rc.1",
"@fluentui/react-switch": "^9.0.10",
"@fluentui/react-tabs": "^9.0.10",
"@fluentui/react-table": "9.0.0-alpha.10",
Expand Down
Loading