Skip to content

fix(SplitButton): Remove borders from hover and pressed state in primary split buttons #25059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopranopillow merged 6 commits into from
Oct 5, 2022
Merged

fix(SplitButton): Remove borders from hover and pressed state in primary split buttons #25059

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
61cd838
fix: Remove border in hover/pressed state of split button.
sopranopillow Oct 3, 2022
4af124a
change file
sopranopillow Oct 3, 2022
1f06771
updating snapshots
sopranopillow Oct 3, 2022
846770b
typo
sopranopillow Oct 3, 2022
d76d60e
updating to only apply styles to primary splitbutton
sopranopillow Oct 4, 2022
9d43bf1
adding requested changes
sopranopillow Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-6cc403c7-709a-479e-b924-84c434c822f3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: Remove border in hover/pressed state of primary button.",
"packageName": "@fluentui/react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
3 changes: 0 additions & 3 deletions packages/react/src/components/Button/ButtonThemes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ export function primaryStyles(theme: ITheme): IButtonStyles {
return {
root: {
backgroundColor: s.primaryButtonBackground,
border: `1px solid ${s.primaryButtonBackground}`,
color: s.primaryButtonText,
selectors: {
[HighContrastSelector]: {
Expand All @@ -179,7 +178,6 @@ export function primaryStyles(theme: ITheme): IButtonStyles {

rootHovered: {
backgroundColor: s.primaryButtonBackgroundHovered,
border: `1px solid ${s.primaryButtonBackgroundHovered}`,
color: s.primaryButtonTextHovered,
selectors: {
[HighContrastSelector]: {
Expand All @@ -192,7 +190,6 @@ export function primaryStyles(theme: ITheme): IButtonStyles {

rootPressed: {
backgroundColor: s.primaryButtonBackgroundPressed,
border: `1px solid ${s.primaryButtonBackgroundPressed}`,
color: s.primaryButtonTextPressed,
selectors: {
[HighContrastSelector]: {
Expand Down
4 changes: 1 addition & 3 deletions ...react/src/components/TeachingBubble/__snapshots__/TeachingBubble.deprecated.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ exports[`TeachingBubble renders renders with hasCloseIcon which is deprecated 1`
background-color: #ffffff;
border-color: #ffffff;
border-radius: 2px;
border: 1px solid #0078d4;
border: 1px solid #8a8886;
box-sizing: border-box;
color: #0078d4;
cursor: pointer;
Expand Down Expand Up @@ -234,7 +234,6 @@ exports[`TeachingBubble renders renders with hasCloseIcon which is deprecated 1`
&:hover {
background-color: #deecf9;
border-color: #deecf9;
border: 1px solid #106ebe;
color: #005a9e;
}
@media screen and (-ms-high-contrast: active), screen and (forced-colors: active){&:hover {
Expand All @@ -252,7 +251,6 @@ exports[`TeachingBubble renders renders with hasCloseIcon which is deprecated 1`
&:active {
background-color: #ffffff;
border-color: #ffffff;
border: 1px solid #005a9e;
color: #0078d4;
}
@media screen and (-ms-high-contrast: active), screen and (forced-colors: active){&:active {
Expand Down
4 changes: 1 addition & 3 deletions packages/react/src/components/TeachingBubble/__snapshots__/TeachingBubble.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ exports[`TeachingBubble renders TeachingBubbleContent with buttons correctly 1`]
background-color: #ffffff;
border-color: #ffffff;
border-radius: 2px;
border: 1px solid #0078d4;
border: 1px solid #8a8886;
box-sizing: border-box;
color: #0078d4;
cursor: pointer;
Expand Down Expand Up @@ -516,7 +516,6 @@ exports[`TeachingBubble renders TeachingBubbleContent with buttons correctly 1`]
&:hover {
background-color: #deecf9;
border-color: #deecf9;
border: 1px solid #106ebe;
color: #005a9e;
}
@media screen and (-ms-high-contrast: active), screen and (forced-colors: active){&:hover {
Expand All @@ -534,7 +533,6 @@ exports[`TeachingBubble renders TeachingBubbleContent with buttons correctly 1`]
&:active {
background-color: #ffffff;
border-color: #ffffff;
border: 1px solid #005a9e;
color: #0078d4;
}
@media screen and (-ms-high-contrast: active), screen and (forced-colors: active){&:active {
Expand Down