fix(create-component): Replace build:local with new generate-api script #24996

TristanWatanabe · 2022-09-28T16:34:19Z

Issue:

When creating a new component via the create-component script, an error will be thrown since it tries to run build:local which has been replaced by the generate-api script in feat: implement internal/alpha/beta/ API removals from package public API surface #23369

Changes:

This PR fixes this issue by replacing build:local with generate-api when creating a new component with create-component.

codesandbox-ci · 2022-09-28T16:46:37Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3235a65:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2022-09-28T16:47:17Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cd88ecf2e2407c308c8364b9167440b9bac171f3 (build)

fabricteam · 2022-09-28T16:52:01Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1568	1584	5000
Button	mount	1139	1162	5000
FluentProvider	mount	1948	1952	5000
FluentProviderWithTheme	mount	769	800	10
FluentProviderWithTheme	virtual-rerender	729	719	10
FluentProviderWithTheme	virtual-rerender-with-unmount	750	774	10
MakeStyles	mount	2320	2316	50000
SpinButton	mount	3089	3066	5000

fabricteam · 2022-09-28T16:54:19Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ChatDuplicateMessagesPerf.default	228	192	1.19:1
SkeletonMinimalPerf.default	285	245	1.16:1
RefMinimalPerf.default	176	157	1.12:1
RadioGroupMinimalPerf.default	372	334	1.11:1
VideoMinimalPerf.default	586	533	1.1:1
TreeMinimalPerf.default	668	615	1.09:1
ButtonMinimalPerf.default	142	131	1.08:1
HeaderMinimalPerf.default	303	284	1.07:1
ReactionMinimalPerf.default	305	286	1.07:1
AlertMinimalPerf.default	192	182	1.05:1
AvatarMinimalPerf.default	160	152	1.05:1
InputMinimalPerf.default	958	915	1.05:1
ChatMinimalPerf.default	608	586	1.04:1
GridMinimalPerf.default	275	265	1.04:1
TextMinimalPerf.default	288	276	1.04:1
HeaderSlotsPerf.default	596	585	1.02:1
ImageMinimalPerf.default	312	307	1.02:1
ItemLayoutMinimalPerf.default	965	948	1.02:1
LoaderMinimalPerf.default	547	537	1.02:1
PortalMinimalPerf.default	140	137	1.02:1
IconMinimalPerf.default	585	572	1.02:1
TooltipMinimalPerf.default	1967	1936	1.02:1
DropdownMinimalPerf.default	2194	2176	1.01:1
EmbedMinimalPerf.default	2957	2931	1.01:1
ListCommonPerf.default	513	506	1.01:1
SplitButtonMinimalPerf.default	3619	3572	1.01:1
ToolbarMinimalPerf.default	774	765	1.01:1
AnimationMinimalPerf.default	429	431	1:1
BoxMinimalPerf.default	279	280	1:1
DialogMinimalPerf.default	644	644	1:1
LabelMinimalPerf.default	314	315	1:1
ProviderMergeThemesPerf.default	1055	1055	1:1
ProviderMinimalPerf.default	337	338	1:1
SegmentMinimalPerf.default	287	286	1:1
CustomToolbarPrototype.default	2256	2253	1:1
FormMinimalPerf.default	309	313	0.99:1
ListNestedPerf.default	452	456	0.99:1
ListWith60ListItems.default	503	508	0.99:1
MenuMinimalPerf.default	697	701	0.99:1
PopupMinimalPerf.default	531	537	0.99:1
SliderMinimalPerf.default	1271	1286	0.99:1
StatusMinimalPerf.default	546	553	0.99:1
TableManyItemsPerf.default	1511	1532	0.99:1
ButtonSlotsPerf.default	451	461	0.98:1
TableMinimalPerf.default	327	333	0.98:1
TextAreaMinimalPerf.default	390	400	0.98:1
DatepickerMinimalPerf.default	4721	4857	0.97:1
AttachmentSlotsPerf.default	904	945	0.96:1
ButtonOverridesMissPerf.default	1059	1102	0.96:1
DropdownManyItemsPerf.default	511	532	0.96:1
ListMinimalPerf.default	404	420	0.96:1
MenuButtonMinimalPerf.default	1282	1336	0.96:1
ChatWithPopoverPerf.default	295	309	0.95:1
CardMinimalPerf.default	405	432	0.94:1
LayoutMinimalPerf.default	265	281	0.94:1
RosterPerf.default	1689	1794	0.94:1
TreeWith60ListItems.default	118	125	0.94:1
CheckboxMinimalPerf.default	1596	1720	0.93:1
FlexMinimalPerf.default	225	242	0.93:1
AccordionMinimalPerf.default	114	128	0.89:1
DividerMinimalPerf.default	293	330	0.89:1
CarouselMinimalPerf.default	327	378	0.87:1
AttachmentMinimalPerf.default	105	134	0.78:1

fabricteam · 2022-09-28T16:56:48Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`2.936 kB` `1.212 kB`
`react-accordion` Accordion (including children components)	`78.914 kB` `24.06 kB`
`react-alert` Alert	`83.822 kB` `21.029 kB`
`react-avatar` Avatar	`48.692 kB` `13.8 kB`
`react-avatar` AvatarGroup	`14.95 kB` `5.989 kB`
`react-avatar` AvatarGroupItem	`68.66 kB` `19.138 kB`
`react-badge` Badge	`22.6 kB` `7.205 kB`
`react-badge` CounterBadge	`23.503 kB` `7.497 kB`
`react-badge` PresenceBadge	`24.05 kB` `7.067 kB`
`react-button` Button	`36.119 kB` `9.647 kB`
`react-button` CompoundButton	`43.144 kB` `10.86 kB`
`react-button` MenuButton	`38.813 kB` `10.551 kB`
`react-button` SplitButton	`46.228 kB` `11.933 kB`
`react-button` ToggleButton	`51.888 kB` `11.127 kB`
`react-card` Card - All	`67.002 kB` `19.261 kB`
`react-card` Card	`62.684 kB` `18.177 kB`
`react-card` CardFooter	`8.561 kB` `3.601 kB`
`react-card` CardHeader	`9.604 kB` `3.94 kB`
`react-card` CardPreview	`8.662 kB` `3.656 kB`
`react-combobox` Combobox (including child components)	`74.636 kB` `24.186 kB`
`react-combobox` Dropdown (including child components)	`74.236 kB` `24.086 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`188.681 kB` `52.366 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.394 kB` `11.007 kB`
`react-dialog` Dialog (including children components)	`82.755 kB` `24.581 kB`
`react-divider` Divider	`16.459 kB` `5.902 kB`
`react-image` Image	`10.78 kB` `4.264 kB`
`react-input` Input	`23.762 kB` `7.706 kB`
`react-label` Label	`9.338 kB` `3.86 kB`
`react-link` Link	`11.784 kB` `4.867 kB`
`react-menu` Menu (including children components)	`116.589 kB` `35.777 kB`
`react-menu` Menu (including selectable components)	`119.658 kB` `36.296 kB`
`react-overflow` hooks only	`10.685 kB` `4.104 kB`
`react-popover` Popover	`102.955 kB` `31.548 kB`
`react-portal` Portal	`10.576 kB` `3.875 kB`
`react-portal-compat` PortalCompatProvider	`5.851 kB` `1.964 kB`
`react-positioning` usePositioning	`19.7 kB` `7.404 kB`
`react-provider` FluentProvider	`15.755 kB` `5.883 kB`
`react-radio` Radio	`35.56 kB` `11.929 kB`
`react-radio` RadioGroup	`14.248 kB` `5.7 kB`
`react-select` Select	`20.846 kB` `7.346 kB`
`react-slider` Slider	`31.526 kB` `10.046 kB`
`react-spinbutton` SpinButton	`44.102 kB` `12.425 kB`
`react-spinner` Spinner	`19.977 kB` `6.438 kB`
`react-switch` Switch	`32.097 kB` `10.27 kB`
`react-text` Text - Default	`11.782 kB` `4.605 kB`
`react-text` Text - Wrappers	`15.092 kB` `5.044 kB`
`react-textarea` Textarea	`25.018 kB` `8.133 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`29.65 kB` `6.444 kB`
`react-theme` Teams: Light theme	`17.486 kB` `5.057 kB`
`react-tooltip` Tooltip	`41.535 kB` `14.639 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against cd88ecf2e2407c308c8364b9167440b9bac171f3}

fabricteam · 2022-09-28T17:09:53Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1217	1222	5000
Breadcrumb	mount	3079	3068	1000
Checkbox	mount	2651	2639	5000
CheckboxBase	mount	2367	2394	5000
ChoiceGroup	mount	4393	4446	5000
ComboBox	mount	1226	1262	1000
CommandBar	mount	9946	9978	1000
ContextualMenu	mount	13777	13585	1000
DefaultButton	mount	1372	1391	5000
DetailsRow	mount	3599	3631	5000
DetailsRowFast	mount	3675	3580	5000
DetailsRowNoStyles	mount	3438	3460	5000
Dialog	mount	3104	3082	1000
DocumentCardTitle	mount	586	574	1000
Dropdown	mount	3434	3237	5000
FocusTrapZone	mount	2033	2048	5000
FocusZone	mount	1990	1996	5000
GroupedList	mount	54568	61140	2
GroupedList	virtual-rerender	25782	25512	2
GroupedList	virtual-rerender-with-unmount	95133	99584	2
GroupedListV2	mount	575	551	2
GroupedListV2	virtual-rerender	522	559	2
GroupedListV2	virtual-rerender-with-unmount	561	566	2
IconButton	mount	1946	1941	5000
Label	mount	734	755	5000
Layer	mount	4265	4279	5000
Link	mount	845	844	5000
MenuButton	mount	1675	1708	5000
MessageBar	mount	2388	2300	5000
Nav	mount	3270	3320	1000
OverflowSet	mount	1419	1406	5000
Panel	mount	2571	2529	1000
Persona	mount	1296	1293	1000
Pivot	mount	1660	1647	1000
PrimaryButton	mount	1533	1545	5000
Rating	mount	7010	7025	5000
SearchBox	mount	1529	1510	5000
Shimmer	mount	2873	2867	5000
Slider	mount	2111	2097	5000
SpinButton	mount	4681	4764	5000
Spinner	mount	807	815	5000
SplitButton	mount	3104	3083	5000
Stack	mount	870	874	5000
StackWithIntrinsicChildren	mount	2355	2374	5000
StackWithTextChildren	mount	4816	4781	5000
SwatchColorPicker	mount	10452	10467	5000
TagPicker	mount	2643	2701	5000
TeachingBubble	mount	104728	105824	5000
Text	mount	810	794	5000
TextField	mount	1612	1607	5000
ThemeProvider	mount	1567	1543	5000
ThemeProvider	virtual-rerender	1072	1067	5000
ThemeProvider	virtual-rerender-with-unmount	2141	2191	5000
Toggle	mount	1120	1140	5000
buttonNative	mount	545	545	5000

…pt (microsoft#24996)

fix: replace build:local script with generate-api

3235a65

TristanWatanabe requested a review from a team as a code owner September 28, 2022 16:34

TristanWatanabe self-assigned this Sep 28, 2022

msft-fluent-ui-bot added the Area: Build System label Sep 28, 2022

github-actions bot added this to the September Project Cycle Q1 2022 milestone Sep 28, 2022

TristanWatanabe closed this Sep 28, 2022

TristanWatanabe reopened this Sep 28, 2022

ling1726 approved these changes Sep 29, 2022

View reviewed changes

TristanWatanabe merged commit 48df172 into microsoft:master Sep 29, 2022

TristanWatanabe deleted the fix-create-component-script branch September 29, 2022 14:52

NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022

fix(create-component): Replace build:local with new generate-api scri…

79ea10f

…pt (microsoft#24996)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(create-component): Replace build:local with new generate-api script #24996

fix(create-component): Replace build:local with new generate-api script #24996

Uh oh!

TristanWatanabe commented Sep 28, 2022

Uh oh!

codesandbox-ci bot commented Sep 28, 2022

Uh oh!

size-auditor bot commented Sep 28, 2022 •

edited

Loading

Uh oh!

fabricteam commented Sep 28, 2022 •

edited

Loading

Uh oh!

fabricteam commented Sep 28, 2022 •

edited

Loading

Uh oh!

fabricteam commented Sep 28, 2022 •

edited

Loading

Uh oh!

fabricteam commented Sep 28, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fix(create-component): Replace build:local with new generate-api script #24996

fix(create-component): Replace build:local with new generate-api script #24996

Uh oh!

Conversation

TristanWatanabe commented Sep 28, 2022

Issue:

Changes:

Uh oh!

codesandbox-ci bot commented Sep 28, 2022

Uh oh!

size-auditor bot commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

size-auditor bot commented Sep 28, 2022 •

edited

Loading

fabricteam commented Sep 28, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Sep 28, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Sep 28, 2022 •

edited

Loading

fabricteam commented Sep 28, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)