feat(react-dialog): removes DialogSurface native dialog support
#24979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3be490f:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1242 | 1168 | 5000 | |
| Button | mount | 889 | 841 | 5000 | |
| FluentProvider | mount | 1550 | 1503 | 5000 | |
| FluentProviderWithTheme | mount | 615 | 640 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 594 | 592 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 555 | 633 | 10 | |
| MakeStyles | mount | 1800 | 1730 | 50000 | |
| SpinButton | mount | 2459 | 2487 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 5eb849d01fd82567ba6ce6d8e9281685d069432e (build) |
bsunderhus
changed the title
as="div" by default
bsunderhus
changed the title
DialogSurface native dialog support
layershifter
approved these changes
Sep 30, 2022
packages/react-components/react-dialog/src/components/DialogSurface/useDialogSurface.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-dialog/src/components/DialogSurface/useDialogSurface.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-dialog/src/components/DialogSurface/useDialogSurface.ts
Outdated
Show resolved
Hide resolved
bsunderhus
force-pushed
the
react-dialog/as-div-by-default
branch
from
e088aae to
3be490f
Compare
GeoffCoxMSFT
pushed a commit
to GeoffCoxMSFT/fluentui
that referenced
this pull request
Oct 3, 2022
…crosoft#24979) * feat(react-dialog): `as="div"` by default * feat: completely remove native dialog support
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…crosoft#24979) * feat(react-dialog): `as="div"` by default * feat: completely remove native dialog support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
After many discussions, the implementation of native
<dialog>as a valid element to be used byDialogSurfacecomponent presented as desirable.New Behavior
The PR #24525 had valid points presented by @layershifter and @Hotell about our matrix support and Safari issues with native
<dialog>element. After some investigations, the support for<dialog>native element as default element forDialogSurfacehas proven to be a challenge (mostly due to Safari's lack of support forHTMLDialogElementmodal methods and also::backdroppseudoelement).With that in mind, this PR reverts
DialogSurfaceto only supportdiv. Having in mind that perhaps in future iterations whenever we have a better browser support this might be added again.