-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Removed the space between the thead and tbody of the Table Component. #24748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 18b1ee8:
|
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 83b033de0fe819bc30cc437ec7c4a83dd4c6997e (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1734 | 1648 | 5000 | |
| Button | mount | 1251 | 1236 | 5000 | |
| FluentProvider | mount | 1883 | 1914 | 5000 | |
| FluentProviderWithTheme | mount | 718 | 705 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 651 | 671 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 716 | 699 | 10 | |
| MakeStyles | mount | 2259 | 2237 | 50000 | |
| SpinButton | mount | 3302 | 3259 | 5000 |
packages/react-components/react-table/src/components/Table/useTableStyles.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Oleksandr Fediashov <[email protected]>
No problem. This was my first ever open-source PR and I learned allot. Maybe next time! Do I simply close this PR myself now? |
Yup feel free to close the PR, I can do that too if you can't. Feel free to keep contributing! It's just unlucky that this contribution is for something under heavy development on our side at the same time |
Current Behavior
This fix affects the react-table package. There is a space between the thead and tbody elements in the table component.

New Behavior
I added 'border-collapse: collapse' property in order to remove the space between the thead and tbody.

Related Issue(s)
Fixes #24439