Skip to content

Conversation

@kboeh
Copy link

@kboeh kboeh commented Sep 9, 2022

Current Behavior

This fix affects the react-table package. There is a space between the thead and tbody elements in the table component.
Before

New Behavior

I added 'border-collapse: collapse' property in order to remove the space between the thead and tbody.
After

Related Issue(s)

Fixes #24439

@ghost
Copy link

ghost commented Sep 9, 2022

CLA assistant check
All CLA requirements met.

@kboeh kboeh marked this pull request as ready for review September 9, 2022 21:12
@kboeh kboeh requested a review from a team as a code owner September 9, 2022 21:12
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 18b1ee8:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 9, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
187.656 kB
51.96 kB
react-components
react-components: FluentProvider & webLightTheme
33.359 kB
11.004 kB
react-portal-compat
PortalCompatProvider
5.851 kB
1.964 kB
🤖 This report was generated against 83b033de0fe819bc30cc437ec7c4a83dd4c6997e

@size-auditor
Copy link

size-auditor bot commented Sep 9, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 83b033de0fe819bc30cc437ec7c4a83dd4c6997e (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 9, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1734 1648 5000
Button mount 1251 1236 5000
FluentProvider mount 1883 1914 5000
FluentProviderWithTheme mount 718 705 10
FluentProviderWithTheme virtual-rerender 651 671 10
FluentProviderWithTheme virtual-rerender-with-unmount 716 699 10
MakeStyles mount 2259 2237 50000
SpinButton mount 3302 3259 5000

@kboeh kboeh requested review from layershifter and removed request for ling1726 September 12, 2022 20:15
@ling1726
Copy link
Contributor

Thanks for the contribution @kboeh 🙏. Unfortunately, there are big changes upcoming in #24762 that are going to be targeted for the next preview release of the table component. The border-collapse styling will be there

@kboeh kboeh closed this Sep 13, 2022
@kboeh
Copy link
Author

kboeh commented Sep 13, 2022

Thanks for the contribution @kboeh 🙏. Unfortunately, there are big changes upcoming in #24762 that are going to be targeted for the next preview release of the table component. The border-collapse styling will be there

No problem. This was my first ever open-source PR and I learned allot. Maybe next time! Do I simply close this PR myself now?

@kboeh kboeh reopened this Sep 13, 2022
@ling1726
Copy link
Contributor

Thanks for the contribution @kboeh 🙏. Unfortunately, there are big changes upcoming in #24762 that are going to be targeted for the next preview release of the table component. The border-collapse styling will be there

No problem. This was my first ever open-source PR and I learned allot. Maybe next time! Do I simply close this PR myself now?

Yup feel free to close the PR, I can do that too if you can't. Feel free to keep contributing! It's just unlucky that this contribution is for something under heavy development on our side at the same time

@kboeh kboeh closed this Sep 13, 2022
@kboeh kboeh deleted the patch/issue24439/table_border branch September 13, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table: there is an unexcepted gap between the thead and tbody elements

5 participants