Skip to content

fix: Replacing bottom border styles with text decoration underline in Link #24734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khmakoto merged 4 commits into from
Sep 12, 2022
Merged

fix: Replacing bottom border styles with text decoration underline in Link #24734

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff5c740
fix: Replacing bottom border styles with text decoration underline in…
Sep 8, 2022
3873aec
Adding change file.
Sep 8, 2022
1b43587
Removing lingering border styles.
Sep 9, 2022
19ffa30
Changing approch from changing textDecorationColor to chaging textDec…
Sep 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-link-ace1a119-44f0-4cac-96a5-b757d4abee30.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: Replacing bottom border styles with text decoration underline.",
"packageName": "@fluentui/react-link",
"email": "[email protected]",
"dependentChangeType": "patch"
}
28 changes: 12 additions & 16 deletions packages/react-components/react-link/src/components/Link/useLinkStyles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,14 @@ export const linkClassNames: SlotClassNames<LinkSlots> = {

const useStyles = makeStyles({
focusIndicator: createCustomFocusIndicatorStyle({
borderBottomColor: 'transparent',
textDecorationColor: tokens.colorStrokeFocus2,
textDecorationLine: 'underline',
textDecorationStyle: 'double',
}),
// Common styles.
root: {
backgroundColor: 'transparent',
borderTopStyle: 'none',
borderLeftStyle: 'none',
borderRightStyle: 'none',
borderBottomColor: 'transparent',
borderBottomStyle: 'solid',
borderBottomWidth: tokens.strokeWidthThin,
...shorthands.borderStyle('none'),
boxSizing: 'border-box',
color: tokens.colorBrandForegroundLink,
cursor: 'pointer',
Expand All @@ -35,17 +29,19 @@ const useStyles = makeStyles({
...shorthands.padding(0),
...shorthands.overflow('inherit'),
textAlign: 'left',
textDecorationLine: 'none',
textDecorationColor: 'transparent',
textDecorationLine: 'underline',
textDecorationThickness: tokens.strokeWidthThin,
textOverflow: 'inherit',
userSelect: 'text',

':hover': {
borderBottomColor: tokens.colorBrandForegroundLinkHover,
textDecorationColor: tokens.colorBrandForegroundLinkHover,
color: tokens.colorBrandForegroundLinkHover,
},

':active': {
borderBottomColor: tokens.colorBrandForegroundLinkPressed,
textDecorationColor: tokens.colorBrandForegroundLinkPressed,
color: tokens.colorBrandForegroundLinkPressed,
},
},
Expand All @@ -58,36 +54,36 @@ const useStyles = makeStyles({
color: tokens.colorNeutralForeground2,

':hover': {
borderBottomColor: tokens.colorNeutralForeground2Hover,
textDecorationColor: tokens.colorNeutralForeground2Hover,
color: tokens.colorNeutralForeground2Hover,
},

':active': {
borderBottomColor: tokens.colorNeutralForeground2Pressed,
textDecorationColor: tokens.colorNeutralForeground2Pressed,
color: tokens.colorNeutralForeground2Pressed,
},
},
// Overrides when the Link is rendered inline within text.
inline: {
borderBottomColor: tokens.colorBrandForegroundLink,
textDecorationColor: tokens.colorBrandForegroundLink,
},
// Overrides when the Link is rendered inline within text and appears subtle.
inlineSubtle: {
borderBottomColor: tokens.colorNeutralForeground2,
},
// Overrides when the Link is disabled.
disabled: {
borderBottomColor: 'transparent',
textDecorationColor: 'transparent',
color: tokens.colorNeutralForegroundDisabled,
cursor: 'not-allowed',

':hover': {
borderBottomColor: 'transparent',
textDecorationColor: 'transparent',
color: tokens.colorNeutralForegroundDisabled,
},

':active': {
borderBottomColor: 'transparent',
textDecorationColor: 'transparent',
color: tokens.colorNeutralForegroundDisabled,
},
},
Expand Down