Skip to content

fix: Combobox text attribute ignored when empty string is passed #24665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micahgodbolt merged 4 commits into from
Oct 27, 2022
+8 −1
Merged

fix: Combobox text attribute ignored when empty string is passed #24665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fe4a49
fix: Combobox text attribute ignored when empty string is passed
Sebbiv Sep 5, 2022
1e81be4
Change file
Sebbiv Sep 5, 2022
666f697
Update change file
Sebbiv Sep 16, 2022
314e6bb
Merge branch 'master' into pr/24665
micahgodbolt Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-f596f7cc-faeb-404e-9c21-006e9137848e.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Allow empty string as valid value for text property of ComboBox",
Copy link
Member

@khmakoto khmakoto Oct 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"comment": "Allow empty string as valid value for text property of ComboBox",
"comment": "fix: Allow empty string as valid value for text property of ComboBox.",

"packageName": "@fluentui/react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react/src/components/ComboBox/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,7 @@ class ComboBoxInternal extends React.Component<IComboBoxInternalProps, IComboBox
// unless we are open and have a valid current pending index
if (
!(isOpen && currentPendingIndexValid) &&
text &&
(text || text === '') &&
(currentPendingValue === null || currentPendingValue === undefined)
) {
return text;
Expand Down