-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Revert "Update "screener-build.yml" to include lage's output" #24609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 61241b5.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 02d1ba6:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 21af8da1d98c070a682b26b7d56775d43a749b3d (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1299 | 1306 | 5000 | |
| Button | mount | 954 | 948 | 5000 | |
| FluentProvider | mount | 1555 | 1589 | 5000 | |
| FluentProviderWithTheme | mount | 632 | 656 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 588 | 595 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 623 | 631 | 10 | |
| MakeStyles | mount | 1870 | 1878 | 50000 | |
| SpinButton | mount | 2654 | 2470 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 131 | 114 | 1.15:1 |
| ChatDuplicateMessagesPerf.default | 255 | 237 | 1.08:1 |
| AvatarMinimalPerf.default | 161 | 150 | 1.07:1 |
| TextMinimalPerf.default | 295 | 275 | 1.07:1 |
| VideoMinimalPerf.default | 628 | 588 | 1.07:1 |
| RadioGroupMinimalPerf.default | 373 | 352 | 1.06:1 |
| ButtonMinimalPerf.default | 133 | 127 | 1.05:1 |
| RefMinimalPerf.default | 182 | 174 | 1.05:1 |
| IconMinimalPerf.default | 547 | 521 | 1.05:1 |
| TextAreaMinimalPerf.default | 390 | 373 | 1.05:1 |
| AccordionMinimalPerf.default | 117 | 113 | 1.04:1 |
| AlertMinimalPerf.default | 229 | 221 | 1.04:1 |
| AttachmentSlotsPerf.default | 945 | 913 | 1.04:1 |
| FormMinimalPerf.default | 320 | 307 | 1.04:1 |
| HeaderMinimalPerf.default | 303 | 293 | 1.03:1 |
| PortalMinimalPerf.default | 143 | 139 | 1.03:1 |
| TreeWith60ListItems.default | 129 | 125 | 1.03:1 |
| AnimationMinimalPerf.default | 448 | 440 | 1.02:1 |
| CarouselMinimalPerf.default | 395 | 389 | 1.02:1 |
| HeaderSlotsPerf.default | 637 | 622 | 1.02:1 |
| LayoutMinimalPerf.default | 301 | 295 | 1.02:1 |
| MenuMinimalPerf.default | 700 | 685 | 1.02:1 |
| PopupMinimalPerf.default | 534 | 522 | 1.02:1 |
| TableMinimalPerf.default | 334 | 329 | 1.02:1 |
| TreeMinimalPerf.default | 679 | 665 | 1.02:1 |
| ButtonOverridesMissPerf.default | 1249 | 1240 | 1.01:1 |
| CardMinimalPerf.default | 432 | 428 | 1.01:1 |
| ChatMinimalPerf.default | 595 | 588 | 1.01:1 |
| DropdownManyItemsPerf.default | 560 | 556 | 1.01:1 |
| DropdownMinimalPerf.default | 2654 | 2623 | 1.01:1 |
| GridMinimalPerf.default | 276 | 272 | 1.01:1 |
| LabelMinimalPerf.default | 308 | 304 | 1.01:1 |
| ListMinimalPerf.default | 420 | 415 | 1.01:1 |
| LoaderMinimalPerf.default | 574 | 567 | 1.01:1 |
| ReactionMinimalPerf.default | 311 | 307 | 1.01:1 |
| SkeletonMinimalPerf.default | 289 | 286 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3655 | 3633 | 1.01:1 |
| StatusMinimalPerf.default | 561 | 556 | 1.01:1 |
| ToolbarMinimalPerf.default | 761 | 756 | 1.01:1 |
| BoxMinimalPerf.default | 275 | 275 | 1:1 |
| ButtonSlotsPerf.default | 453 | 454 | 1:1 |
| CheckboxMinimalPerf.default | 2247 | 2241 | 1:1 |
| DialogMinimalPerf.default | 643 | 641 | 1:1 |
| DividerMinimalPerf.default | 291 | 291 | 1:1 |
| EmbedMinimalPerf.default | 3413 | 3424 | 1:1 |
| InputMinimalPerf.default | 1082 | 1078 | 1:1 |
| ItemLayoutMinimalPerf.default | 986 | 985 | 1:1 |
| ListNestedPerf.default | 461 | 459 | 1:1 |
| MenuButtonMinimalPerf.default | 1414 | 1416 | 1:1 |
| ProviderMergeThemesPerf.default | 1057 | 1062 | 1:1 |
| SegmentMinimalPerf.default | 284 | 283 | 1:1 |
| SliderMinimalPerf.default | 1416 | 1412 | 1:1 |
| TableManyItemsPerf.default | 1557 | 1555 | 1:1 |
| ListCommonPerf.default | 515 | 519 | 0.99:1 |
| ListWith60ListItems.default | 506 | 513 | 0.99:1 |
| RosterPerf.default | 1752 | 1772 | 0.99:1 |
| ProviderMinimalPerf.default | 329 | 331 | 0.99:1 |
| CustomToolbarPrototype.default | 2419 | 2440 | 0.99:1 |
| TooltipMinimalPerf.default | 1966 | 1990 | 0.99:1 |
| DatepickerMinimalPerf.default | 4760 | 4869 | 0.98:1 |
| FlexMinimalPerf.default | 227 | 231 | 0.98:1 |
| ImageMinimalPerf.default | 316 | 321 | 0.98:1 |
| ChatWithPopoverPerf.default | 304 | 317 | 0.96:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 725 | 732 | 5000 | |
| Breadcrumb | mount | 2441 | 2450 | 1000 | |
| Checkbox | mount | 2256 | 2174 | 5000 | |
| CheckboxBase | mount | 1970 | 1950 | 5000 | |
| ChoiceGroup | mount | 3682 | 3930 | 5000 | |
| ComboBox | mount | 798 | 751 | 1000 | |
| CommandBar | mount | 8738 | 8736 | 1000 | |
| ContextualMenu | mount | 10621 | 10782 | 1000 | |
| DefaultButton | mount | 880 | 862 | 5000 | |
| DetailsRow | mount | 3024 | 3242 | 5000 | |
| DetailsRowFast | mount | 3067 | 3115 | 5000 | |
| DetailsRowNoStyles | mount | 3026 | 3034 | 5000 | |
| Dialog | mount | 2604 | 2497 | 1000 | |
| DocumentCardTitle | mount | 134 | 139 | 1000 | |
| Dropdown | mount | 2659 | 2600 | 5000 | |
| FocusTrapZone | mount | 1529 | 1546 | 5000 | |
| FocusZone | mount | 1442 | 1411 | 5000 | |
| IconButton | mount | 1396 | 1435 | 5000 | |
| Label | mount | 293 | 273 | 5000 | |
| Layer | mount | 3773 | 3618 | 5000 | |
| Link | mount | 396 | 380 | 5000 | |
| MenuButton | mount | 1156 | 1130 | 5000 | |
| MessageBar | mount | 1772 | 1647 | 5000 | |
| Nav | mount | 2726 | 2607 | 1000 | |
| OverflowSet | mount | 872 | 860 | 5000 | |
| Panel | mount | 1964 | 1968 | 1000 | |
| Persona | mount | 813 | 826 | 1000 | |
| Pivot | mount | 1133 | 1165 | 1000 | |
| PrimaryButton | mount | 1064 | 968 | 5000 | |
| Rating | mount | 6390 | 5938 | 5000 | |
| SearchBox | mount | 1103 | 973 | 5000 | |
| Shimmer | mount | 2358 | 2242 | 5000 | |
| Slider | mount | 1579 | 1513 | 5000 | |
| SpinButton | mount | 4090 | 3898 | 5000 | |
| Spinner | mount | 381 | 335 | 5000 | |
| SplitButton | mount | 2509 | 2571 | 5000 | |
| Stack | mount | 427 | 386 | 5000 | |
| StackWithIntrinsicChildren | mount | 1712 | 1779 | 5000 | |
| StackWithTextChildren | mount | 4036 | 4230 | 5000 | |
| SwatchColorPicker | mount | 10107 | 9423 | 5000 | |
| TagPicker | mount | 2119 | 2231 | 5000 | |
| TeachingBubble | mount | 86345 | 84833 | 5000 | |
| Text | mount | 337 | 364 | 5000 | |
| TextField | mount | 1085 | 1188 | 5000 | |
| ThemeProvider | mount | 1027 | 1072 | 5000 | |
| ThemeProvider | virtual-rerender | 643 | 647 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1640 | 1713 | 5000 | |
| Toggle | mount | 601 | 668 | 5000 | |
| buttonNative | mount | 123 | 103 | 5000 |
Reverts #24586
The solution for the issue concerning
lagehas been discovered and will be fixed in the PR #24606 so logging lage's output is no longer needed.