Skip to content

Conversation

@ralucapelin
Copy link
Contributor

@ralucapelin ralucapelin commented Aug 31, 2022

Reverts #24586

The solution for the issue concerning lage has been discovered and will be fixed in the PR #24606 so logging lage's output is no longer needed.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 02d1ba6:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Aug 31, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 21af8da1d98c070a682b26b7d56775d43a749b3d (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1299 1306 5000
Button mount 954 948 5000
FluentProvider mount 1555 1589 5000
FluentProviderWithTheme mount 632 656 10
FluentProviderWithTheme virtual-rerender 588 595 10
FluentProviderWithTheme virtual-rerender-with-unmount 623 631 10
MakeStyles mount 1870 1878 50000
SpinButton mount 2654 2470 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
2.936 kB
1.212 kB
react-accordion
Accordion (including children components)
79.349 kB
24.053 kB
react-alert
Alert
83.79 kB
20.841 kB
react-avatar
Avatar
48.283 kB
13.644 kB
react-avatar
AvatarGroup
14.85 kB
5.942 kB
react-avatar
AvatarGroupItem
68.251 kB
18.987 kB
react-badge
Badge
22.503 kB
7.153 kB
react-badge
CounterBadge
23.406 kB
7.449 kB
react-badge
PresenceBadge
23.947 kB
7.022 kB
react-button
Button
36.396 kB
9.579 kB
react-button
CompoundButton
43.469 kB
10.812 kB
react-button
MenuButton
39.014 kB
10.456 kB
react-button
SplitButton
46.544 kB
11.84 kB
react-button
ToggleButton
51.91 kB
11.003 kB
react-card
Card - All
67.458 kB
19.264 kB
react-card
Card
63.14 kB
18.176 kB
react-card
CardFooter
8.461 kB
3.555 kB
react-card
CardHeader
9.504 kB
3.896 kB
react-card
CardPreview
8.562 kB
3.61 kB
react-combobox
Combobox (including child components)
73.757 kB
23.969 kB
react-combobox
Dropdown (including child components)
73.344 kB
23.876 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
188.818 kB
51.901 kB
react-components
react-components: FluentProvider & webLightTheme
33.259 kB
10.951 kB
react-dialog
Dialog (including children components)
85.361 kB
25.458 kB
react-divider
Divider
16.359 kB
5.853 kB
react-image
Image
10.68 kB
4.215 kB
react-input
Input
23.498 kB
7.617 kB
react-label
Label
9.238 kB
3.815 kB
react-link
Link
12.231 kB
4.925 kB
react-menu
Menu (including children components)
115.697 kB
35.316 kB
react-menu
Menu (including selectable components)
118.896 kB
35.806 kB
react-overflow
hooks only
10.685 kB
4.104 kB
react-popover
Popover
102.837 kB
31.496 kB
react-portal
Portal
10.576 kB
3.875 kB
react-positioning
usePositioning
19.7 kB
7.404 kB
react-provider
FluentProvider
15.655 kB
5.835 kB
react-radio
Radio
36.025 kB
11.914 kB
react-radio
RadioGroup
14.148 kB
5.654 kB
react-select
Select
20.746 kB
7.299 kB
react-slider
Slider
32.07 kB
10.033 kB
react-spinbutton
SpinButton
43.843 kB
12.336 kB
react-spinner
Spinner
19.855 kB
6.384 kB
react-switch
Switch
32.562 kB
10.253 kB
react-text
Text - Default
11.682 kB
4.561 kB
react-text
Text - Wrappers
14.992 kB
4.995 kB
react-textarea
Textarea
23.674 kB
7.83 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.548 kB
6.433 kB
react-theme
Teams: Light theme
17.452 kB
5.053 kB
react-tooltip
Tooltip
41.504 kB
14.622 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against 21af8da1d98c070a682b26b7d56775d43a749b3d

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2022

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 131 114 1.15:1
ChatDuplicateMessagesPerf.default 255 237 1.08:1
AvatarMinimalPerf.default 161 150 1.07:1
TextMinimalPerf.default 295 275 1.07:1
VideoMinimalPerf.default 628 588 1.07:1
RadioGroupMinimalPerf.default 373 352 1.06:1
ButtonMinimalPerf.default 133 127 1.05:1
RefMinimalPerf.default 182 174 1.05:1
IconMinimalPerf.default 547 521 1.05:1
TextAreaMinimalPerf.default 390 373 1.05:1
AccordionMinimalPerf.default 117 113 1.04:1
AlertMinimalPerf.default 229 221 1.04:1
AttachmentSlotsPerf.default 945 913 1.04:1
FormMinimalPerf.default 320 307 1.04:1
HeaderMinimalPerf.default 303 293 1.03:1
PortalMinimalPerf.default 143 139 1.03:1
TreeWith60ListItems.default 129 125 1.03:1
AnimationMinimalPerf.default 448 440 1.02:1
CarouselMinimalPerf.default 395 389 1.02:1
HeaderSlotsPerf.default 637 622 1.02:1
LayoutMinimalPerf.default 301 295 1.02:1
MenuMinimalPerf.default 700 685 1.02:1
PopupMinimalPerf.default 534 522 1.02:1
TableMinimalPerf.default 334 329 1.02:1
TreeMinimalPerf.default 679 665 1.02:1
ButtonOverridesMissPerf.default 1249 1240 1.01:1
CardMinimalPerf.default 432 428 1.01:1
ChatMinimalPerf.default 595 588 1.01:1
DropdownManyItemsPerf.default 560 556 1.01:1
DropdownMinimalPerf.default 2654 2623 1.01:1
GridMinimalPerf.default 276 272 1.01:1
LabelMinimalPerf.default 308 304 1.01:1
ListMinimalPerf.default 420 415 1.01:1
LoaderMinimalPerf.default 574 567 1.01:1
ReactionMinimalPerf.default 311 307 1.01:1
SkeletonMinimalPerf.default 289 286 1.01:1
SplitButtonMinimalPerf.default 3655 3633 1.01:1
StatusMinimalPerf.default 561 556 1.01:1
ToolbarMinimalPerf.default 761 756 1.01:1
BoxMinimalPerf.default 275 275 1:1
ButtonSlotsPerf.default 453 454 1:1
CheckboxMinimalPerf.default 2247 2241 1:1
DialogMinimalPerf.default 643 641 1:1
DividerMinimalPerf.default 291 291 1:1
EmbedMinimalPerf.default 3413 3424 1:1
InputMinimalPerf.default 1082 1078 1:1
ItemLayoutMinimalPerf.default 986 985 1:1
ListNestedPerf.default 461 459 1:1
MenuButtonMinimalPerf.default 1414 1416 1:1
ProviderMergeThemesPerf.default 1057 1062 1:1
SegmentMinimalPerf.default 284 283 1:1
SliderMinimalPerf.default 1416 1412 1:1
TableManyItemsPerf.default 1557 1555 1:1
ListCommonPerf.default 515 519 0.99:1
ListWith60ListItems.default 506 513 0.99:1
RosterPerf.default 1752 1772 0.99:1
ProviderMinimalPerf.default 329 331 0.99:1
CustomToolbarPrototype.default 2419 2440 0.99:1
TooltipMinimalPerf.default 1966 1990 0.99:1
DatepickerMinimalPerf.default 4760 4869 0.98:1
FlexMinimalPerf.default 227 231 0.98:1
ImageMinimalPerf.default 316 321 0.98:1
ChatWithPopoverPerf.default 304 317 0.96:1

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 725 732 5000
Breadcrumb mount 2441 2450 1000
Checkbox mount 2256 2174 5000
CheckboxBase mount 1970 1950 5000
ChoiceGroup mount 3682 3930 5000
ComboBox mount 798 751 1000
CommandBar mount 8738 8736 1000
ContextualMenu mount 10621 10782 1000
DefaultButton mount 880 862 5000
DetailsRow mount 3024 3242 5000
DetailsRowFast mount 3067 3115 5000
DetailsRowNoStyles mount 3026 3034 5000
Dialog mount 2604 2497 1000
DocumentCardTitle mount 134 139 1000
Dropdown mount 2659 2600 5000
FocusTrapZone mount 1529 1546 5000
FocusZone mount 1442 1411 5000
IconButton mount 1396 1435 5000
Label mount 293 273 5000
Layer mount 3773 3618 5000
Link mount 396 380 5000
MenuButton mount 1156 1130 5000
MessageBar mount 1772 1647 5000
Nav mount 2726 2607 1000
OverflowSet mount 872 860 5000
Panel mount 1964 1968 1000
Persona mount 813 826 1000
Pivot mount 1133 1165 1000
PrimaryButton mount 1064 968 5000
Rating mount 6390 5938 5000
SearchBox mount 1103 973 5000
Shimmer mount 2358 2242 5000
Slider mount 1579 1513 5000
SpinButton mount 4090 3898 5000
Spinner mount 381 335 5000
SplitButton mount 2509 2571 5000
Stack mount 427 386 5000
StackWithIntrinsicChildren mount 1712 1779 5000
StackWithTextChildren mount 4036 4230 5000
SwatchColorPicker mount 10107 9423 5000
TagPicker mount 2119 2231 5000
TeachingBubble mount 86345 84833 5000
Text mount 337 364 5000
TextField mount 1085 1188 5000
ThemeProvider mount 1027 1072 5000
ThemeProvider virtual-rerender 643 647 5000
ThemeProvider virtual-rerender-with-unmount 1640 1713 5000
Toggle mount 601 668 5000
buttonNative mount 123 103 5000

@ralucapelin ralucapelin marked this pull request as ready for review August 31, 2022 14:27
@ralucapelin ralucapelin requested a review from a team as a code owner August 31, 2022 14:27
@ralucapelin ralucapelin merged commit c4dfe67 into master Sep 5, 2022
@ralucapelin ralucapelin deleted the revert-24586-debug-lage branch September 5, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants