Skip to content

Fix artifact downloading race condition #24607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralucapelin merged 4 commits into from
Aug 31, 2022
Merged

Fix artifact downloading race condition #24607

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f09a9d
Download artifact from workflow that triggered current run
Aug 31, 2022
b7e62c1
Syntax correction
Aug 31, 2022
b7db21d
Fix typo
Aug 31, 2022
9238a65
Use correct github context to get run id
Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/screener-run.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ jobs:
uses: dawidd6/action-download-artifact@v2
with:
workflow: screener-build.yml
workflow_conclusion: success
Copy link
Member

@layershifter layershifter Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: why workflow_conclusion is removed?
A: Do not specify pr, commit, branch, run_id together or workflow_conclusion and run_id together. Pick just one of each or none. https://github.com/dawidd6/action-download-artifact#usage

run_id: ${{github.event.workflow_run.id}}
name: env-artifact

- name: Download N* storybook artifact
uses: dawidd6/action-download-artifact@v2
with:
workflow: screener-build.yml
workflow_conclusion: success
run_id: ${{github.event.workflow_run.id}}
name: northstar-artifact
# downloads artifact to where it would be 'built'
path: packages/fluentui/docs/dist
Expand Down Expand Up @@ -118,14 +118,14 @@ jobs:
uses: dawidd6/action-download-artifact@v2
with:
workflow: screener-build.yml
workflow_conclusion: success
run_id: ${{github.event.workflow_run.id}}
name: env-artifact

- name: Download screener storybook artifact
uses: dawidd6/action-download-artifact@v2
with:
workflow: screener-build.yml
workflow_conclusion: success
run_id: ${{github.event.workflow_run.id}}
name: screener-artifact
path: apps/vr-tests/dist/storybook
if: ${{ env.IS_ARTIFACT_PRESENT == 'true' }}
Expand Down Expand Up @@ -192,14 +192,14 @@ jobs:
uses: dawidd6/action-download-artifact@v2
with:
workflow: screener-build.yml
workflow_conclusion: success
run_id: ${{github.event.workflow_run.id}}
name: env-artifact

- name: Download VNext storybook artifact
uses: dawidd6/action-download-artifact@v2
with:
workflow: screener-build.yml
workflow_conclusion: success
run_id: ${{github.event.workflow_run.id}}
name: vnext-artifact
path: apps/vr-tests-react-components/dist/storybook
if: ${{ env.IS_ARTIFACT_PRESENT == 'true' }}
Expand Down