-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add tests for hover states #24390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AtishayMsft
merged 24 commits into
microsoft:master
from
krkshitij:usr/krkshitij/test-hover-state
Sep 12, 2022
Merged
Add tests for hover states #24390
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
7c5d794
Add test case for AreaChart hover state
krkshitij d650523
Add enzyme-to-json package
krkshitij 0a82a7a
Remove _rectRef
krkshitij 12a9372
Add test case for DonutChart hover state
krkshitij c878e09
Update callout snapshot
krkshitij 640ab3d
Add test case for LineChart hover state
krkshitij 2c1d88b
Add test case for GroupedBarChart hover state
krkshitij 637319a
Add test case for HeatMapChart hover state
krkshitij 589749d
Add test case for HorizontalBarChart hover state
krkshitij 690badc
Add test case for StackedBarChart hover state
krkshitij 9a7b5db
Add test case for VerticalBarChart hover state
krkshitij 06fbaa6
Add test case for VertStackedBarChart hover state
krkshitij e91497d
Mock Math.random()
krkshitij ee760fe
Remove Legends measurement snapshot
krkshitij 78d9b93
Add comments
krkshitij abe3170
Add change file
krkshitij d24adea
Add more test cases
krkshitij d161618
Remove duplicate code
krkshitij 41aaf48
Update snapshots
krkshitij cc6ef04
Replace callout text with complete HTML comparison
krkshitij 84da7b8
Update Math.random() mock
krkshitij 131d65b
Update snapshots
krkshitij 380c32b
Move dependency to root
krkshitij cc08b01
Update @types/enzyme
krkshitij File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-charting-dfdb7954-3e89-4f57-8428-742aa68c065a.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "none", | ||
| "comment": "Add tests for hover states", | ||
| "packageName": "@fluentui/react-charting", | ||
| "email": "[email protected]", | ||
| "dependentChangeType": "none" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also test callout for stack and custom callouts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try moving the mouse hover and observe the callout changing positions and values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay