-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: Publish react-field package, and export from react-components/unstable #24235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
behowell
merged 9 commits into
microsoft:master
from
behowell:field/add-to-react-components
Sep 12, 2022
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e134d83
feat: Add *Field components to @fluentui/react-components/unstable
behowell 7522f96
Add preview warning to description.md files
behowell fd27804
Remove Best Practices section from Field until it can be written
behowell 39fc02c
Updating change files
behowell 2a9b737
Update change files
behowell e219ad6
Fix beachball disallowedChangeTypes for react-field
behowell 76b7c37
Merge branch 'master' of https://github.com/microsoft/fluentui into f…
behowell 437fb2f
Remove private: false
behowell 1366cb6
Merge branch 'master' of https://github.com/microsoft/fluentui into f…
behowell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-components-de1ae615-fbbf-4fd4-8957-40d69ff9414f.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "feat: Add *Field components to @fluentui/react-components/unstable", | ||
| "packageName": "@fluentui/react-components", | ||
| "email": "[email protected]", | ||
| "dependentChangeType": "patch" | ||
| } |
7 changes: 7 additions & 0 deletions
7
change/@fluentui-react-field-e888af0f-e684-4f66-8f86-8c950a9bb41e.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "prerelease", | ||
| "comment": "Initial release", | ||
| "packageName": "@fluentui/react-field", | ||
| "email": "[email protected]", | ||
| "dependentChangeType": "patch" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...ct-components/react-field/src/stories/CheckboxField/CheckboxFieldDescription.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,16 @@ | ||
| CheckboxField adds a validation message and hint text to the Checkbox control. | ||
|
|
||
| Unlike other Field controls, the `label` appears to the right of the checkbox, as it does for the `Checkbox` control. If a standard field label is required, use the `fieldLabel` prop. | ||
|
|
||
| <!-- Don't allow prettier to collapse code block into single line --> | ||
| <!-- prettier-ignore --> | ||
| > **⚠️ Preview components are considered unstable:** | ||
| > | ||
| > ```jsx | ||
| > | ||
| > import { CheckboxField } from '@fluentui/react-components/unstable'; | ||
| > | ||
| > ``` | ||
| > | ||
| > - Features and APIs may change before final release | ||
| > - Please contact us if you intend to use this in your product |
13 changes: 13 additions & 0 deletions
13
...ct-components/react-field/src/stories/ComboboxField/ComboboxFieldDescription.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,14 @@ | ||
| ComboboxField adds a Label, validation message, and hint text to the Combobox control. | ||
|
|
||
| <!-- Don't allow prettier to collapse code block into single line --> | ||
| <!-- prettier-ignore --> | ||
| > **⚠️ Preview components are considered unstable:** | ||
| > | ||
| > ```jsx | ||
| > | ||
| > import { ComboboxField } from '@fluentui/react-components/unstable'; | ||
| > | ||
| > ``` | ||
| > | ||
| > - Features and APIs may change before final release | ||
| > - Please contact us if you intend to use this in your product |
5 changes: 0 additions & 5 deletions
5
packages/react-components/react-field/src/stories/Field/FieldBestPractices.md
This file was deleted.
Oops, something went wrong.
5 changes: 5 additions & 0 deletions
5
packages/react-components/react-field/src/stories/Field/FieldDescription.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,6 @@ | ||
| Fields are a combination of the underlying control with a Label, validation message, and hint text. | ||
|
|
||
| > **⚠️ Preview components are considered unstable:** | ||
| > | ||
| > - Features and APIs may change before final release | ||
| > - Please contact us if you intend to use this in your product |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...es/react-components/react-field/src/stories/InputField/InputFieldDescription.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,14 @@ | ||
| InputField adds a Label, validation message, and hint text to the Input control. | ||
|
|
||
| <!-- Don't allow prettier to collapse code block into single line --> | ||
| <!-- prettier-ignore --> | ||
| > **⚠️ Preview components are considered unstable:** | ||
| > | ||
| > ```jsx | ||
| > | ||
| > import { InputField } from '@fluentui/react-components/unstable'; | ||
| > | ||
| > ``` | ||
| > | ||
| > - Features and APIs may change before final release | ||
| > - Please contact us if you intend to use this in your product |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#24735 tracks adding this back once the best practices have been written.