Skip to content

v7 Calendar cherry-pick: remove explicit readonly semantics from grid and gridcells #23990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smhigley merged 4 commits into from
Jul 22, 2022
Merged

v7 Calendar cherry-pick: remove explicit readonly semantics from grid and gridcells #23990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a4b9ae
Remove explicit readonly semantics from Calendar grid
smhigley Jul 19, 2022
9f71368
Change files
smhigley Jul 19, 2022
eafef66
better change file comment
smhigley Jul 19, 2022
742929c
better change file comment
smhigley Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@uifabric-date-time-35097027-415c-4e27-aa17-e0ab9da80cd3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: Remove explicit readonly semantics from Calendar grid.",
"packageName": "@uifabric/date-time",
"email": "[email protected]",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/office-ui-fabric-react-f0ac52c6-050f-4369-b9ef-0d4bbb005c43.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: Remove explicit readonly semantics from Calendar grid.",
"packageName": "office-ui-fabric-react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
1 change: 0 additions & 1 deletion packages/date-time/src/components/Calendar/CalendarYear/CalendarYear.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ const CalendarYearGridCell = React.forwardRef(
aria-label={String(year)}
aria-selected={selected}
ref={mergedRef}
aria-readonly={true} // prevent grid from being "editable"
>
{onRenderYear?.(year) ?? year}
</button>
Expand Down
1 change: 0 additions & 1 deletion packages/date-time/src/components/CalendarDayGrid/CalendarDayGrid.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,6 @@ export const CalendarDayGridBase = React.forwardRef(
<FocusZone className={classNames.wrapper} ref={forwardedRef}>
<table
className={classNames.table}
aria-readonly="true"
aria-multiselectable="false"
aria-labelledby={labelledBy}
aria-activedescendant={activeDescendantId}
Expand Down
1 change: 0 additions & 1 deletion packages/date-time/src/components/CalendarDayGrid/CalendarGridDayCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,6 @@ export const CalendarGridDayCell: React.FunctionComponent<ICalendarGridDayCellPr
onKeyDown={!ariaHidden ? onDayKeyDown : undefined}
role="gridcell"
tabIndex={isNavigatedDate ? 0 : undefined}
aria-readonly="true"
aria-current={day.isSelected ? 'date' : undefined}
aria-selected={day.isInBounds ? day.isSelected : undefined}
data-is-focusable={!ariaHidden && (allFocusable || (day.isInBounds ? true : undefined))}
Expand Down
44 changes: 0 additions & 44 deletions ...ages/date-time/src/components/WeeklyDayPicker/__snapshots__/WeeklyDayPicker.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<table
aria-activedescendant="id__0"
aria-multiselectable="false"
aria-readonly="true"
className=

{
Expand Down Expand Up @@ -586,7 +585,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -700,7 +698,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -814,7 +811,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -928,7 +924,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1042,7 +1037,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1156,7 +1150,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1270,7 +1263,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1389,7 +1381,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1519,7 +1510,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1649,7 +1639,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1779,7 +1768,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1910,7 +1898,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-current="date"
aria-disabled={false}
aria-readonly="true"
aria-selected={true}
className=

Expand Down Expand Up @@ -2083,7 +2070,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -2209,7 +2195,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -2351,7 +2336,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -2461,7 +2445,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -2571,7 +2554,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -2681,7 +2663,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -2791,7 +2772,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -2901,7 +2881,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -3011,7 +2990,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -3332,7 +3310,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<table
aria-activedescendant="id__0"
aria-multiselectable="false"
aria-readonly="true"
className=

{
Expand Down Expand Up @@ -3794,7 +3771,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -3908,7 +3884,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4022,7 +3997,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4136,7 +4110,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4250,7 +4223,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4364,7 +4336,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4478,7 +4449,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4597,7 +4567,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4727,7 +4696,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4858,7 +4826,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-current="date"
aria-disabled={false}
aria-readonly="true"
aria-selected={true}
className=

Expand Down Expand Up @@ -5031,7 +4998,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -5157,7 +5123,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -5283,7 +5248,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -5409,7 +5373,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -5551,7 +5514,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -5661,7 +5623,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -5771,7 +5732,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -5881,7 +5841,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -5991,7 +5950,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -6101,7 +6059,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -6211,7 +6168,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down
Loading