chore: Mark teams-prg owned APIs with @internal #23689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goes through the packages owned by teams-prg and adds @internal to APIs that are not intended for public use
Collaborator
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 11ebf8a:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 18a0c05530dff13ff19e69652bf4eb6c47ecaa3c (build) |
|
|
||
| /** | ||
| * Resets generated IDs, should be used only in tests. | ||
| * |
Member
There was a problem hiding this comment.
So this is no longer internal?
Contributor
Author
There was a problem hiding this comment.
this shouldn't be internal actually, because in order to have deterministic ids in unit tests, users will need to invoke this utility
miroslavstastny
approved these changes
Jun 23, 2022
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1416 | 1449 | 5000 | |
| Button | mount | 1121 | 1108 | 5000 | |
| FluentProvider | mount | 2029 | 2111 | 5000 | |
| FluentProviderWithTheme | mount | 777 | 783 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 728 | 710 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 771 | 805 | 10 | |
| MakeStyles | mount | 2113 | 2163 | 50000 |
rohitpagariya
pushed a commit
to rohitpagariya/fluentui
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes through the packages owned by teams-prg and adds @internal to APIs
that are not intended for public use
Follow up from #23577