Remove useTheme export #23335
Merged
Remove useTheme export #23335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
commented
May 31, 2022
| Pick<FluentProviderProps, 'targetDocument'> & | ||
| Required<Pick<FluentProviderProps, 'dir'>> & { | ||
| theme: Theme | Partial<Theme> | undefined; | ||
| theme: ThemeContextValue; |
Member
Author
There was a problem hiding this comment.
There were 5 or 6 instances of this specific typing, so I extracted it.
Member
There was a problem hiding this comment.
Is this related to the useTheme change?
Collaborator
📊 Bundle size report
Unchanged fixtures
|
spmonahan
approved these changes
May 31, 2022
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 287cf6769bda0ca0ec7cd29b01a4a4481a488d92 (build) |
miroslavstastny
previously requested changes
May 31, 2022
Member
miroslavstastny
left a comment
miroslavstastny
left a comment
There was a problem hiding this comment.
We should go with #23325 instead.
Member
Author
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6ad5978:
|
| @@ -1,4 +1,5 @@ | |||
| export { ThemeContext, useTheme } from './ThemeContext'; | |||
| export { ThemeContext } from './ThemeContext'; | |||
| export type { ThemeContextValue } from './ThemeContext'; | |||
Member
There was a problem hiding this comment.
in #23325 we are moving react-shared-contexts to unstable. Does this have any effect on exporting this type from the unstable package?
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1225 | 1219 | 5000 | |
| Button | mount | 767 | 737 | 5000 | |
| FluentProvider | mount | 2231 | 2219 | 5000 | |
| FluentProviderWithTheme | mount | 388 | 393 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 355 | 359 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 422 | 405 | 10 | |
| MakeStyles | mount | 2024 | 1985 | 50000 |
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
* remove useTheme from exports * run yarn change * fix bad merge * fix type export * remove export useTheme * update react-provider change json * update react-provider api snapshot Co-authored-by: Sean Monahan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
useThemeexport as it is no longer needed. If you need access to design tokens, import them directly: