react-avatar: Creating AvatarGroupItem component #23287
Conversation
sopranopillow
added
Fluent UI react-components (v9)
Component: AvatarGroup
| "$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json", | ||
| "extends": "./api-extractor.json", | ||
| "mainEntryPointFilePath": "<projectFolder>/dist/packages/react-components/<unscopedPackageName>/src/index.d.ts" | ||
| "mainEntryPointFilePath": "<projectFolder>/dist/types/packages/react-components/<unscopedPackageName>/src/index.d.ts" |
There was a problem hiding this comment.
Out of curiosity, why is this change needed in this PR?
There was a problem hiding this comment.
create-component added it, it doesn't seem to affect anything though. I can remove it just in case?
There was a problem hiding this comment.
I'm not really sure what this actually does. But if it was added by create-component, and it doesn't break things, then it should be fine.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 84bd8c2:
|
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 02b03646728acb14672b664dcdffe7bd8bac1087 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1092 | 1107 | 5000 | |
| Button | mount | 693 | 689 | 5000 | |
| FluentProvider | mount | 2384 | 2328 | 5000 | |
| FluentProviderWithTheme | mount | 388 | 373 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 293 | 298 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 398 | 363 | 10 | |
| MakeStyles | mount | 1938 | 1879 | 50000 |
3 participants
This PR creates the
AvatarGroupItemcomponent that will be used by AvatarGroup.Related Issue(s)
#22240 and #22736