(chore) Move react-badge to react-components subfolder #22890

TristanWatanabe · 2022-05-06T21:56:08Z

Changes

Moves @fluentui/react-badge to react-components common folder using move-packages nx generator.

Related Issue(s)

Part of #22427

codesandbox-ci · 2022-05-06T22:02:51Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d511194:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

size-auditor · 2022-05-06T22:09:27Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8ab3a2ac23ee12d9b5fbd72d3b4593fb3691209b (build)

fabricteam · 2022-05-06T22:11:21Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Button	mount	579	573	5000	Possible regression
FluentProviderWithTheme	mount	275	273	10	Possible regression
FluentProviderWithTheme	virtual-rerender	243	238	10	Possible regression
FluentProviderWithTheme	virtual-rerender-with-unmount	304	325	10	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	964	905	5000
Button	mount	579	573	5000	Possible regression
FluentProvider	mount	1829	1842	5000
FluentProviderWithTheme	mount	275	273	10	Possible regression
FluentProviderWithTheme	virtual-rerender	243	238	10	Possible regression
FluentProviderWithTheme	virtual-rerender-with-unmount	304	325	10	Possible regression
MakeStyles	mount	1595	1573	50000

fabricteam · 2022-05-06T22:14:45Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ListCommonPerf.default	689	594	1.16:1
ProviderMinimalPerf.default	420	387	1.09:1
AlertMinimalPerf.default	289	267	1.08:1
ListMinimalPerf.default	544	503	1.08:1
ReactionMinimalPerf.default	416	385	1.08:1
ToolbarMinimalPerf.default	1010	938	1.08:1
ChatWithPopoverPerf.default	409	383	1.07:1
IconMinimalPerf.default	651	607	1.07:1
TreeWith60ListItems.default	177	166	1.07:1
AttachmentMinimalPerf.default	153	145	1.06:1
ChatMinimalPerf.default	769	726	1.06:1
GridMinimalPerf.default	356	335	1.06:1
HeaderSlotsPerf.default	803	755	1.06:1
AttachmentSlotsPerf.default	1182	1130	1.05:1
CarouselMinimalPerf.default	489	464	1.05:1
ChatDuplicateMessagesPerf.default	289	274	1.05:1
AccordionMinimalPerf.default	149	143	1.04:1
ButtonOverridesMissPerf.default	1600	1543	1.04:1
DropdownManyItemsPerf.default	716	688	1.04:1
ItemLayoutMinimalPerf.default	1251	1203	1.04:1
PortalMinimalPerf.default	181	174	1.04:1
SegmentMinimalPerf.default	346	333	1.04:1
TextMinimalPerf.default	349	334	1.04:1
ImageMinimalPerf.default	377	367	1.03:1
RefMinimalPerf.default	239	232	1.03:1
RosterPerf.default	1147	1126	1.02:1
RadioGroupMinimalPerf.default	447	439	1.02:1
TableMinimalPerf.default	399	391	1.02:1
CardMinimalPerf.default	568	561	1.01:1
DatepickerMinimalPerf.default	6031	5951	1.01:1
DropdownMinimalPerf.default	3091	3059	1.01:1
InputMinimalPerf.default	1321	1308	1.01:1
LayoutMinimalPerf.default	341	339	1.01:1
LoaderMinimalPerf.default	711	701	1.01:1
MenuMinimalPerf.default	867	861	1.01:1
ProviderMergeThemesPerf.default	1310	1296	1.01:1
SplitButtonMinimalPerf.default	4524	4480	1.01:1
TableManyItemsPerf.default	1979	1957	1.01:1
TooltipMinimalPerf.default	1157	1148	1.01:1
DialogMinimalPerf.default	777	775	1:1
FormMinimalPerf.default	426	424	1:1
ListNestedPerf.default	559	559	1:1
ListWith60ListItems.default	662	659	1:1
AvatarMinimalPerf.default	179	181	0.99:1
BoxMinimalPerf.default	349	353	0.99:1
ButtonMinimalPerf.default	160	162	0.99:1
ButtonSlotsPerf.default	568	573	0.99:1
EmbedMinimalPerf.default	4246	4340	0.98:1
MenuButtonMinimalPerf.default	1724	1760	0.98:1
SliderMinimalPerf.default	1743	1770	0.98:1
StatusMinimalPerf.default	674	690	0.98:1
CustomToolbarPrototype.default	2759	2805	0.98:1
HeaderMinimalPerf.default	361	374	0.97:1
LabelMinimalPerf.default	367	380	0.97:1
SkeletonMinimalPerf.default	344	353	0.97:1
AnimationMinimalPerf.default	550	570	0.96:1
CheckboxMinimalPerf.default	2725	2832	0.96:1
PopupMinimalPerf.default	616	642	0.96:1
FlexMinimalPerf.default	282	296	0.95:1
TreeMinimalPerf.default	790	832	0.95:1
VideoMinimalPerf.default	634	664	0.95:1
DividerMinimalPerf.default	340	374	0.91:1
TextAreaMinimalPerf.default	464	525	0.88:1

fabricteam · 2022-05-06T22:16:05Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`priority-overflow` createOverflowManager	`2.936 kB` `1.212 kB`
`react-accordion` Accordion (including children components)	`73.834 kB` `22.534 kB`
`react-avatar` Avatar	`45.51 kB` `13.25 kB`
`react-badge` Badge	`21.1 kB` `6.671 kB`
`react-badge` CounterBadge	`22.015 kB` `6.976 kB`
`react-badge` PresenceBadge	`22.346 kB` `6.715 kB`
`react-button` Button	`32.591 kB` `9.056 kB`
`react-button` CompoundButton	`38.836 kB` `10.221 kB`
`react-button` MenuButton	`34.381 kB` `9.645 kB`
`react-button` SplitButton	`41.662 kB` `10.95 kB`
`react-button` ToggleButton	`43.518 kB` `9.984 kB`
`react-card` Card - All	`59.102 kB` `16.957 kB`
`react-card` Card	`54.387 kB` `15.706 kB`
`react-card` CardFooter	`7.891 kB` `3.363 kB`
`react-card` CardHeader	`9.463 kB` `3.881 kB`
`react-card` CardPreview	`7.863 kB` `3.391 kB`
`react-combobox` Combobox	`60.892 kB` `20.814 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`179.74 kB` `50.168 kB`
`react-components` react-components: FluentProvider & webLightTheme	`34.178 kB` `11.138 kB`
`react-divider` Divider	`15.65 kB` `5.636 kB`
`react-image` Image	`10.314 kB` `4.06 kB`
`react-input` Input	`22.274 kB` `7.336 kB`
`react-label` Label	`8.644 kB` `3.614 kB`
`react-link` Link	`11.52 kB` `4.69 kB`
`react-menu` Menu (including children components)	`110.335 kB` `33.584 kB`
`react-menu` Menu (including selectable components)	`113.51 kB` `34.053 kB`
`react-overflow` hooks only	`10.792 kB` `4.124 kB`
`react-popover` Popover	`101.258 kB` `30.847 kB`
`react-portal` Portal	`6.272 kB` `2.17 kB`
`react-positioning` usePopper	`23.21 kB` `8.084 kB`
`react-provider` FluentProvider	`14.227 kB` `5.336 kB`
`react-radio` Radio	`29.568 kB` `10.122 kB`
`react-radio` RadioGroup	`13.751 kB` `5.515 kB`
`react-select` Select	`17.176 kB` `6.408 kB`
`react-slider` Slider	`25.657 kB` `8.302 kB`
`react-spinbutton` SpinButton	`41.985 kB` `11.908 kB`
`react-spinner` Spinner	`17.895 kB` `5.988 kB`
`react-switch` Switch	`25.539 kB` `8.286 kB`
`react-text` Text - Default	`11.002 kB` `4.336 kB`
`react-text` Text - Wrappers	`14.324 kB` `4.749 kB`
`react-textarea` Textarea	`21.318 kB` `7.211 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.363 kB` `7.043 kB`
`react-theme` Teams: Light theme	`19.806 kB` `5.699 kB`
`react-tooltip` Tooltip	`43.039 kB` `14.819 kB`
`react-utilities` SSRProvider	`189 B` `161 B`

_{🤖 This report was generated against 8ab3a2ac23ee12d9b5fbd72d3b4593fb3691209b}

fabricteam · 2022-05-06T22:25:49Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	920	917	5000
Breadcrumb	mount	2806	2807	1000
Checkbox	mount	1513	1511	5000
CheckboxBase	mount	1314	1364	5000
ChoiceGroup	mount	4825	4855	5000
ComboBox	mount	1014	973	1000
CommandBar	mount	10737	10768	1000
ContextualMenu	mount	11847	11763	1000
DefaultButton	mount	1193	1202	5000
DetailsRow	mount	3895	3935	5000
DetailsRowFast	mount	3947	3934	5000
DetailsRowNoStyles	mount	3763	3772	5000
Dialog	mount	2298	2382	1000
DocumentCardTitle	mount	167	183	1000
Dropdown	mount	3405	3364	5000
FocusTrapZone	mount	1861	1882	5000
FocusZone	mount	1894	1893	5000
IconButton	mount	1794	1821	5000
Label	mount	362	365	5000
Layer	mount	3065	3029	5000
Link	mount	489	482	5000
MenuButton	mount	1504	1540	5000
MessageBar	mount	2162	2135	5000
Nav	mount	3393	3355	1000
OverflowSet	mount	1118	1122	5000
Panel	mount	2273	2270	1000
Persona	mount	1040	1030	1000
Pivot	mount	1551	1498	1000
PrimaryButton	mount	1344	1325	5000
Rating	mount	7965	7951	5000
SearchBox	mount	1349	1340	5000
Shimmer	mount	2558	2601	5000
Slider	mount	2041	2025	5000
SpinButton	mount	5179	5180	5000
Spinner	mount	456	437	5000
SplitButton	mount	3209	3266	5000
Stack	mount	519	545	5000
StackWithIntrinsicChildren	mount	2373	2338	5000
StackWithTextChildren	mount	5364	5317	5000
SwatchColorPicker	mount	11871	11819	5000
TagPicker	mount	2813	2775	5000
TeachingBubble	mount	94413	94348	5000
Text	mount	429	432	5000
TextField	mount	1449	1466	5000
ThemeProvider	mount	1228	1245	5000
ThemeProvider	virtual-rerender	659	669	5000
ThemeProvider	virtual-rerender-with-unmount	1970	1962	5000
Toggle	mount	813	824	5000
buttonNative	mount	126	131	5000

This reverts commit 9236ce9.

TristanWatanabe added 2 commits May 6, 2022 14:52

move react-badge

9236ce9

Change File

9b71031

TristanWatanabe added Area: Build System Status: Do Not Merge 🚫 labels May 6, 2022

TristanWatanabe requested review from a team as code owners May 6, 2022 21:56

TristanWatanabe self-assigned this May 6, 2022

TristanWatanabe requested review from a team, JustSlone, behowell and jurokapsiar as code owners May 6, 2022 21:56

TristanWatanabe mentioned this pull request May 6, 2022

group vNext to common folder (as people will start check vNext) #22427

Closed

23 tasks

ling1726 approved these changes May 9, 2022

View reviewed changes

khmakoto approved these changes May 9, 2022

View reviewed changes

Hotell approved these changes May 10, 2022

View reviewed changes

JustSlone approved these changes May 13, 2022

View reviewed changes

TristanWatanabe added 3 commits May 17, 2022 08:34

Revert "move react-badge"

a771ce9

This reverts commit 9236ce9.

Merge branch 'master' into move-react-badge

504bd1d

move react-badge

5dd39e3

TristanWatanabe removed the Status: Do Not Merge 🚫 label May 17, 2022

TristanWatanabe closed this May 17, 2022

TristanWatanabe reopened this May 17, 2022

TristanWatanabe closed this May 17, 2022

TristanWatanabe reopened this May 17, 2022

Merge branch 'master' into move-react-badge

d511194

TristanWatanabe merged commit 2769e4b into microsoft:master May 18, 2022

TristanWatanabe deleted the move-react-badge branch May 18, 2022 02:43

marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022

(chore) Move react-badge to react-components subfolder (microsoft#22890)

a522a66

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

(chore) Move react-badge to react-components subfolder #22890

(chore) Move react-badge to react-components subfolder #22890

Uh oh!

TristanWatanabe commented May 6, 2022 •

edited

Loading

Uh oh!

codesandbox-ci bot commented May 6, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented May 6, 2022 •

edited

Loading

Uh oh!

fabricteam commented May 6, 2022 •

edited

Loading

Uh oh!

fabricteam commented May 6, 2022 •

edited

Loading

Uh oh!

fabricteam commented May 6, 2022 •

edited

Loading

Uh oh!

fabricteam commented May 6, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

(chore) Move react-badge to react-components subfolder #22890

(chore) Move react-badge to react-components subfolder #22890

Uh oh!

Conversation

TristanWatanabe commented May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Related Issue(s)

Uh oh!

codesandbox-ci bot commented May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

size-auditor bot commented May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

fabricteam commented May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented May 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

TristanWatanabe commented May 6, 2022 •

edited

Loading

codesandbox-ci bot commented May 6, 2022 •

edited

Loading

size-auditor bot commented May 6, 2022 •

edited

Loading

fabricteam commented May 6, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented May 6, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented May 6, 2022 •

edited

Loading

fabricteam commented May 6, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)