feat: add time element on nativeElementMap #22848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsunderhus
force-pushed
the
time-element-getNativeElementProps
branch
from
5db2477 to
0ac25f3
Compare
Collaborator
📊 Bundle size report
🤖 This report was generated against c416a93f71a2a4e9b78fbed720750c275a8cd4ae |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0ac25f3:
|
layershifter
approved these changes
May 5, 2022
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 937 | 923 | 5000 | |
| Button | mount | 559 | 540 | 5000 | |
| FluentProvider | mount | 1849 | 1861 | 5000 | |
| FluentProviderWithTheme | mount | 258 | 282 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 249 | 235 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 302 | 314 | 10 | |
| MakeStyles | mount | 1575 | 1565 | 50000 |
ling1726
approved these changes
May 5, 2022
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c416a93f71a2a4e9b78fbed720750c275a8cd4ae (build) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
getNativeElementPropsdoesn't support elementNew Behavior
Adds
<time>element and it's properties togetNativeElementProps