Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "react-radio: remove required indicator from label",
"packageName": "@fluentui/react-radio",
"email": "[email protected]",
"dependentChangeType": "patch"
}
5 changes: 5 additions & 0 deletions packages/react-radio/src/components/Radio/Radio.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ describe('Radio', () => {
const { getByRole, getByLabelText } = render(<Radio label="Test Label" />);
expect(getByRole('radio')).toBe(getByLabelText('Test Label'));
});
it('renders a required radio', () => {
const { getByRole, getByLabelText } = render(<Radio label="Required Label" required />);
expect(getByRole('radio')).toBe(getByLabelText('Required Label'));
expect((getByRole('radio') as HTMLInputElement).required).toBe(true);
});

it('forwards ID to input element', () => {
const { getByRole } = render(<Radio id="test-id" />);
Expand Down
2 changes: 0 additions & 2 deletions packages/react-radio/src/components/Radio/useRadio.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ export const useRadio_unstable = (props: RadioProps, ref: React.Ref<HTMLInputEle
defaultChecked = group.defaultValue !== undefined ? group.defaultValue === props.value : undefined,
labelPosition = group.layout === 'horizontalStacked' ? 'below' : 'after',
disabled = group.disabled,
required,
onChange,
} = props;

Expand Down Expand Up @@ -58,7 +57,6 @@ export const useRadio_unstable = (props: RadioProps, ref: React.Ref<HTMLInputEle
defaultProps: {
htmlFor: input.id,
disabled,
required,
},
});

Expand Down