Skip to content

Link: Adding hrefs to all non-button stories #22774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khmakoto merged 3 commits into from
May 2, 2022
Merged

Link: Adding hrefs to all non-button stories #22774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc1b4ab
Link: Adding hrefs to all non-button stories.
May 2, 2022
4904db9
Update packages/react-components/react-link/src/stories/LinkInline.st…
khmakoto May 2, 2022
55d6176
Update packages/react-components/react-link/src/stories/LinkInline.st…
khmakoto May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/react-components/react-link/src/stories/LinkAppearance.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import * as React from 'react';
import { Link } from '../index';

export const Appearance = () => <Link appearance="subtle">Subtle link</Link>;
export const Appearance = () => (
<Link appearance="subtle" href="https://www.bing.com">
Subtle link
</Link>
);
6 changes: 5 additions & 1 deletion packages/react-components/react-link/src/stories/LinkDefault.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import * as React from 'react';
import { Link, LinkProps } from '../index';

export const Default = (props: LinkProps) => <Link {...props}>This is a link</Link>;
export const Default = (props: LinkProps & { as?: 'a' }) => (
<Link href="https://www.bing.com" {...props}>
This is a link
</Link>
);
6 changes: 5 additions & 1 deletion packages/react-components/react-link/src/stories/LinkDisabled.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
import * as React from 'react';
import { Link } from '../index';

export const Disabled = () => <Link disabled>Disabled link</Link>;
export const Disabled = () => (
<Link disabled href="https://www.bing.com">
Disabled link
</Link>
);
2 changes: 1 addition & 1 deletion packages/react-components/react-link/src/stories/LinkDisabledFocusable.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import * as React from 'react';
import { Link } from '../index';

export const DisabledFocusable = () => (
<Link inline disabled disabledFocusable>
<Link inline disabled disabledFocusable href="https://www.bing.com">
Disabled but still focusable
</Link>
);
6 changes: 5 additions & 1 deletion packages/react-components/react-link/src/stories/LinkInline.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ import { Link } from '../index';

export const Inline = () => (
<div>
This is an <Link inline>inline link</Link> used alongside other text
This is an
<Link href="https://www.bing.com" inline>
inline link
</Link>
used alongside other text
</div>
);