Skip to content

Conversation

@sopranopillow
Copy link
Contributor

@sopranopillow sopranopillow commented May 2, 2022

This PR fixes the example CustomMenuList from ContextualMenu where filtering the menu list removes the link item. This is due to the menu item using the property name instead of text.

Current Behavior

Link disappears out of the list after filtering the list due to using the deprecated name instead of text.

New Behavior

Link will not disappear after being filtered.

Related Issue(s)

Fixes #21256

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f1275a5:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against ace1c2193cbff237cb4cda006dad4ed7f8eb1e74

@size-auditor
Copy link

size-auditor bot commented May 2, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ace1c2193cbff237cb4cda006dad4ed7f8eb1e74 (build)

@sopranopillow sopranopillow merged commit 7833785 into microsoft:master May 3, 2022
@sopranopillow sopranopillow deleted the docs-patch branch May 3, 2022 00:42
marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants