Skip to content

(chore) Move react-spinbutton, react-spinner, react-tooltip to react-components subfolder #22756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TristanWatanabe merged 4 commits into from
May 3, 2022
Merged

(chore) Move react-spinbutton, react-spinner, react-tooltip to react-components subfolder #22756

TristanWatanabe merged 4 commits into from
May 3, 2022

Conversation

@TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented May 2, 2022

Changes

  • Moves @fluentui/react-spinbutton, @fluentui/react-spinner and @fluentui/react-tooltip to react-components common folder using move-packages nx generator.

Related Issue(s)

Part of #22427

@TristanWatanabe TristanWatanabe mentioned this pull request May 2, 2022
Closed
23 tasks
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 79ecc87:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented May 2, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: c69f41a024139eb9ba6b07dea493699317f1da3d (build)

@fabricteam
Copy link
Collaborator

fabricteam commented May 2, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 932 933 5000
Button mount 570 591 5000
FluentProvider mount 1923 1840 5000
FluentProviderWithTheme mount 265 252 10
FluentProviderWithTheme virtual-rerender 220 238 10
FluentProviderWithTheme virtual-rerender-with-unmount 308 327 10
MakeStyles mount 1714 1711 50000

@fabricteam
Copy link
Collaborator

fabricteam commented May 2, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 73.754 kB
22.494 kB
react-badge
Badge		 20.965 kB
6.605 kB
react-badge
CounterBadge		 21.918 kB
6.919 kB
react-badge
PresenceBadge		 22.005 kB
6.582 kB
react-combobox
Combobox		 60.564 kB
20.751 kB
react-divider
Divider		 15.455 kB
5.57 kB
react-overflow
hooks only		 10.792 kB
4.125 kB
react-positioning
usePopper		 23.21 kB
8.084 kB
react-radio
Radio		 23.556 kB
7.898 kB
react-radio
RadioGroup		 8.205 kB
3.516 kB
react-switch
Switch		 24.401 kB
8.024 kB
react-textarea
Textarea		 20.672 kB
7.07 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 31.347 kB
7.04 kB
react-theme
Teams: Light theme		 19.792 kB
5.694 kB
react-utilities
SSRProvider		 189 B
161 B
🤖 This report was generated against d36d823ae024c36d13c1b41764ac5095e7fabe44

@fabricteam
Copy link
Collaborator

fabricteam commented May 2, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 127 108 1.18:1
LayoutMinimalPerf.default 302 257 1.18:1
HeaderMinimalPerf.default 292 257 1.14:1
DropdownManyItemsPerf.default 558 492 1.13:1
TextMinimalPerf.default 289 255 1.13:1
ButtonMinimalPerf.default 142 127 1.12:1
MenuButtonMinimalPerf.default 1405 1264 1.11:1
AccordionMinimalPerf.default 122 111 1.1:1
ChatDuplicateMessagesPerf.default 241 219 1.1:1
ChatMinimalPerf.default 598 555 1.08:1
LoaderMinimalPerf.default 565 524 1.08:1
SkeletonMinimalPerf.default 299 279 1.07:1
AnimationMinimalPerf.default 436 413 1.06:1
PortalMinimalPerf.default 131 124 1.06:1
TableMinimalPerf.default 343 324 1.06:1
ReactionMinimalPerf.default 323 308 1.05:1
DialogMinimalPerf.default 634 611 1.04:1
FormMinimalPerf.default 336 324 1.04:1
ListWith60ListItems.default 548 528 1.04:1
RadioGroupMinimalPerf.default 359 344 1.04:1
VideoMinimalPerf.default 518 496 1.04:1
ButtonOverridesMissPerf.default 1203 1167 1.03:1
LabelMinimalPerf.default 325 317 1.03:1
PopupMinimalPerf.default 515 498 1.03:1
CheckboxMinimalPerf.default 2186 2150 1.02:1
DatepickerMinimalPerf.default 4747 4667 1.02:1
EmbedMinimalPerf.default 3408 3338 1.02:1
SplitButtonMinimalPerf.default 3617 3534 1.02:1
CustomToolbarPrototype.default 2288 2252 1.02:1
TreeWith60ListItems.default 146 143 1.02:1
DividerMinimalPerf.default 294 292 1.01:1
DropdownMinimalPerf.default 2503 2481 1.01:1
ButtonSlotsPerf.default 448 446 1:1
ChatWithPopoverPerf.default 325 324 1:1
InputMinimalPerf.default 1078 1074 1:1
MenuMinimalPerf.default 705 706 1:1
ProviderMergeThemesPerf.default 1072 1075 1:1
ProviderMinimalPerf.default 324 324 1:1
StatusMinimalPerf.default 564 563 1:1
ToolbarMinimalPerf.default 760 761 1:1
TooltipMinimalPerf.default 909 906 1:1
BoxMinimalPerf.default 277 281 0.99:1
FlexMinimalPerf.default 226 228 0.99:1
RefMinimalPerf.default 196 197 0.99:1
CardMinimalPerf.default 453 462 0.98:1
TreeMinimalPerf.default 668 679 0.98:1
GridMinimalPerf.default 242 250 0.97:1
ItemLayoutMinimalPerf.default 934 964 0.97:1
RosterPerf.default 892 916 0.97:1
ListNestedPerf.default 440 456 0.96:1
IconMinimalPerf.default 488 507 0.96:1
AlertMinimalPerf.default 215 226 0.95:1
CarouselMinimalPerf.default 368 388 0.95:1
SegmentMinimalPerf.default 263 281 0.94:1
TextAreaMinimalPerf.default 370 395 0.94:1
ListCommonPerf.default 501 538 0.93:1
SliderMinimalPerf.default 1295 1410 0.92:1
AttachmentSlotsPerf.default 852 933 0.91:1
TableManyItemsPerf.default 1424 1557 0.91:1
HeaderSlotsPerf.default 563 628 0.9:1
ListMinimalPerf.default 379 420 0.9:1
ImageMinimalPerf.default 270 302 0.89:1
AvatarMinimalPerf.default 135 157 0.86:1

@fabricteam
Copy link
Collaborator

fabricteam commented May 2, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 804 783 5000
Breadcrumb mount 2382 2141 1000
Checkbox mount 1256 1272 5000
CheckboxBase mount 1090 1115 5000
ChoiceGroup mount 3969 3928 5000
ComboBox mount 844 857 1000
CommandBar mount 8848 8630 1000
ContextualMenu mount 10025 9996 1000
DefaultButton mount 992 908 5000
DetailsRow mount 3254 3278 5000
DetailsRowFast mount 3131 3211 5000
DetailsRowNoStyles mount 3018 2982 5000
Dialog mount 1939 1885 1000
DocumentCardTitle mount 148 150 1000
Dropdown mount 2692 2823 5000
FocusTrapZone mount 1578 1567 5000
FocusZone mount 1525 1500 5000
IconButton mount 1509 1491 5000
Label mount 294 269 5000
Layer mount 2342 2376 5000
Link mount 401 347 5000
MenuButton mount 1111 1208 5000
MessageBar mount 1784 1847 5000
Nav mount 2647 2825 1000
OverflowSet mount 867 946 5000
Panel mount 1895 1838 1000
Persona mount 813 862 1000
Pivot mount 1239 1180 1000
PrimaryButton mount 1071 1020 5000
Rating mount 6274 6605 5000
SearchBox mount 1064 1129 5000
Shimmer mount 2071 2068 5000
Slider mount 1612 1627 5000
SpinButton mount 4253 4314 5000
Spinner mount 366 371 5000
SplitButton mount 2714 2703 5000
Stack mount 437 454 5000
StackWithIntrinsicChildren mount 1972 1914 5000
StackWithTextChildren mount 4466 4367 5000
SwatchColorPicker mount 9570 9679 5000
TagPicker mount 2305 2356 5000
TeachingBubble mount 80115 81565 5000
Text mount 369 326 5000
TextField mount 1210 1234 5000
ThemeProvider mount 981 985 5000
ThemeProvider virtual-rerender 516 487 5000
ThemeProvider virtual-rerender-with-unmount 1620 1596 5000
Toggle mount 595 589 5000
buttonNative mount 121 104 5000

@TristanWatanabe TristanWatanabe marked this pull request as ready for review May 2, 2022 20:17
@TristanWatanabe TristanWatanabe merged commit b69511e into microsoft:master May 3, 2022
@TristanWatanabe TristanWatanabe deleted the move-cxe-red-pkgs-batch-3 branch May 3, 2022 13:10
marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022
@TristanWatanabe @marwan38
(chore) Move react-spinbutton, react-spinner, react-tooltip to react-…
97feeba 
…components subfolder (microsoft#22756)

* move react-spinbutton

* move react-spinner

* move react-tooltip

* Change Files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spmonahan spmonahan spmonahan approved these changes

@behowell behowell Awaiting requested review from behowell

@khmakoto khmakoto Awaiting requested review from khmakoto

@JustSlone JustSlone Awaiting requested review from JustSlone JustSlone is a code owner

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

+2 more reviewers

@ling1726 ling1726 ling1726 approved these changes

@tomi-msft tomi-msft tomi-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TristanWatanabe TristanWatanabe

Labels

Area: Build System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@TristanWatanabe @fabricteam @ling1726 @tomi-msft @spmonahan @GeoffCoxMSFT