Skip to content

Conversation

@miroslavstastny
Copy link
Member

Update alias color tokens.

1) Brand stroke (Dark theme slot to be Brand 100)
image

2) Compound Brand Background (Dark theme slot)
image

Fixes #22685

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 2, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d1e0971:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-theme
Teams: all themes
31.347 kB
7.04 kB
31.349 kB
7.04 kB
2 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)
73.754 kB
22.494 kB
react-badge
Badge
20.965 kB
6.605 kB
react-badge
CounterBadge
21.918 kB
6.919 kB
react-badge
PresenceBadge
22.005 kB
6.582 kB
react-combobox
Combobox
60.564 kB
20.751 kB
react-divider
Divider
15.455 kB
5.57 kB
react-overflow
hooks only
10.792 kB
4.125 kB
react-positioning
usePopper
23.21 kB
8.084 kB
react-radio
Radio
23.556 kB
7.898 kB
react-radio
RadioGroup
8.205 kB
3.516 kB
react-spinbutton
SpinButton
41.955 kB
11.856 kB
react-spinner
Spinner
17.292 kB
5.865 kB
react-switch
Switch
24.401 kB
8.024 kB
react-textarea
Textarea
20.672 kB
7.07 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: Light theme
19.792 kB
5.694 kB
react-tooltip
Tooltip
42.907 kB
14.761 kB
🤖 This report was generated against a6dffdbc85219e361d77deada85df37e7a3e6de0

@size-auditor
Copy link

size-auditor bot commented May 2, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: a6dffdbc85219e361d77deada85df37e7a3e6de0 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 828 795 5000
Button mount 542 509 5000
FluentProvider mount 1745 1784 5000
FluentProviderWithTheme mount 257 268 10
FluentProviderWithTheme virtual-rerender 220 266 10
FluentProviderWithTheme virtual-rerender-with-unmount 280 270 10
MakeStyles mount 1521 1391 50000

@miroslavstastny miroslavstastny merged commit 3e0ff75 into microsoft:master May 3, 2022
@miroslavstastny miroslavstastny deleted the fix/alias-compound-brand-background branch May 3, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Dark theme token slot adjustment

5 participants