Skip to content

feat(v9): migrate card,dialog,image,text to ship rolluped only dts #22708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hotell merged 6 commits into from
May 3, 2022
Merged

feat(v9): migrate card,dialog,image,text to ship rolluped only dts #22708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd7846f
style: fix formatting issues introduced by manually renaming package
Hotell Apr 29, 2022
8ae7d17
feat(v9): migrate card,dialog,image to ship rolluped only dts
Hotell Apr 29, 2022
2493490
generate change files
Hotell Apr 29, 2022
3b9d29d
fixup! feat(v9): migrate card,dialog,image to ship rolluped only dts
Hotell May 2, 2022
c4da42f
fixup! generate change files
Hotell May 2, 2022
8b9b784
fix(scripts): make sure api-extractor always runs for v9 no matter if…
Hotell May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-card-7f3d21c8-ee65-4256-b92b-a5744e456a0d.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "feat: ship rolluped only dts",
"packageName": "@fluentui/react-card",
"email": "[email protected]",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-image-d64ad1ba-6317-467c-a6e0-4dcf772fdd03.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "feat: ship rolluped only dts",
"packageName": "@fluentui/react-image",
"email": "[email protected]",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-text-161a4d77-6681-453b-bee6-99e039532301.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "feat: ship rolluped only dts",
"packageName": "@fluentui/react-text",
"email": "[email protected]",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions packages/react-components/react-card/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ e2e/
etc/
node_modules/
src/
dist/types/
temp/
__fixtures__
__mocks__
Expand Down
3 changes: 2 additions & 1 deletion packages/react-components/react-card/config/api-extractor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",
"extends": "@fluentui/scripts/api-extractor/api-extractor.common.v-next.json"
"extends": "@fluentui/scripts/api-extractor/api-extractor.common.v-next.json",
"mainEntryPointFilePath": "<projectFolder>/dist/types/index.d.ts"
}
2 changes: 1 addition & 1 deletion packages/react-components/react-card/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"description": "Card container components for Fluent UI React.",
"main": "lib-commonjs/index.js",
"module": "lib/index.js",
"typings": "lib/index.d.ts",
"typings": "dist/index.d.ts",
"sideEffects": false,
"repository": {
"type": "git",
Expand Down
2 changes: 2 additions & 0 deletions packages/react-components/react-card/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
"lib": ["ES2019", "dom"],
"outDir": "dist",
"declaration": true,
"declarationDir": "dist/types",
"inlineSources": true,
"types": ["static-assets", "environment"]
},
"exclude": [
Expand Down
1 change: 1 addition & 0 deletions packages/react-components/react-dialog/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ e2e/
etc/
node_modules/
src/
dist/types/
temp/
__fixtures__
__mocks__
Expand Down
3 changes: 2 additions & 1 deletion packages/react-components/react-dialog/config/api-extractor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",
"extends": "@fluentui/scripts/api-extractor/api-extractor.common.v-next.json"
"extends": "@fluentui/scripts/api-extractor/api-extractor.common.v-next.json",
"mainEntryPointFilePath": "<projectFolder>/dist/types/index.d.ts"
}
2 changes: 1 addition & 1 deletion packages/react-components/react-dialog/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"description": "Dialog component for Fluent UI React",
"main": "lib-commonjs/index.js",
"module": "lib/index.js",
"typings": "lib/index.d.ts",
"typings": "dist/index.d.ts",
"sideEffects": false,
"repository": {
"type": "git",
Expand Down
2 changes: 2 additions & 0 deletions packages/react-components/react-dialog/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
"lib": ["ES2019", "dom"],
"outDir": "dist",
"declaration": true,
"declarationDir": "dist/types",
"inlineSources": true,
"types": ["static-assets", "environment"]
},
"exclude": [
Expand Down
1 change: 1 addition & 0 deletions packages/react-components/react-image/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ e2e/
etc/
node_modules/
src/
dist/types/
temp/
__fixtures__
__mocks__
Expand Down
3 changes: 2 additions & 1 deletion packages/react-components/react-image/config/api-extractor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",
"extends": "@fluentui/scripts/api-extractor/api-extractor.common.v-next.json"
"extends": "@fluentui/scripts/api-extractor/api-extractor.common.v-next.json",
"mainEntryPointFilePath": "<projectFolder>/dist/types/index.d.ts"
}
2 changes: 1 addition & 1 deletion packages/react-components/react-image/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Fluent UI React Image component.",
"main": "lib-commonjs/index.js",
"module": "lib/index.js",
"typings": "lib/index.d.ts",
"typings": "dist/index.d.ts",
"sideEffects": false,
"repository": {
"type": "git",
Expand Down
2 changes: 2 additions & 0 deletions packages/react-components/react-image/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
"lib": ["ES2019", "dom"],
"outDir": "dist",
"declaration": true,
"declarationDir": "dist/types",
"inlineSources": true,
"types": ["static-assets", "environment"]
},
"exclude": [
Expand Down
1 change: 1 addition & 0 deletions packages/react-components/react-text/.npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ e2e/
etc/
node_modules/
src/
dist/types/
temp/
__fixtures__
__mocks__
Expand Down
3 changes: 2 additions & 1 deletion packages/react-components/react-text/config/api-extractor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json",
"extends": "@fluentui/scripts/api-extractor/api-extractor.common.v-next.json"
"extends": "@fluentui/scripts/api-extractor/api-extractor.common.v-next.json",
"mainEntryPointFilePath": "<projectFolder>/dist/types/index.d.ts"
}
2 changes: 1 addition & 1 deletion packages/react-components/react-text/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Text is a typography and styling abstraction component that can be used to ensure the consistency of all text across your application.",
"main": "lib-commonjs/index.js",
"module": "lib/index.js",
"typings": "lib/index.d.ts",
"typings": "dist/index.d.ts",
"sideEffects": false,
"repository": {
"type": "git",
Expand Down
2 changes: 2 additions & 0 deletions packages/react-components/react-text/tsconfig.lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
"lib": ["ES2019", "dom"],
"outDir": "dist",
"declaration": true,
"declarationDir": "dist/types",
"inlineSources": true,
"types": ["static-assets", "environment"]
},
"exclude": [
Expand Down
3 changes: 2 additions & 1 deletion scripts/just.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ export function preset() {
'copy',
'sass',
'ts',
condition('api-extractor', () => !args.min),
// v9 needs to run api-extractor which generates rolluped .d.ts files that are shipped to npm
condition('api-extractor', () => isConvergedPackage() || !args.min),
),
).cached();

Expand Down
2 changes: 1 addition & 1 deletion tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@
"@fluentui/react-link": ["packages/react-components/react-link/src/index.ts"],
"@fluentui/react-list": ["packages/react-components/react-list/src/index.ts"],
"@fluentui/react-menu": ["packages/react-components/react-menu/src/index.ts"],
"@fluentui/react-overflow": ["packages/react-overflow/src/index.ts"],
"@fluentui/react-popover": ["packages/react-components/react-popover/src/index.ts"],
"@fluentui/react-portal": ["packages/react-components/react-portal/src/index.ts"],
"@fluentui/react-portal-compat": ["packages/react-portal-compat/src/index.ts"],
"@fluentui/react-portal-compat-context": ["packages/react-portal-compat-context/src/index.ts"],
"@fluentui/react-positioning": ["packages/react-positioning/src/index.ts"],
"@fluentui/react-overflow": ["packages/react-overflow/src/index.ts"],
"@fluentui/react-provider": ["packages/react-components/react-provider/src/index.ts"],
"@fluentui/react-radio": ["packages/react-radio/src/index.ts"],
"@fluentui/react-select": ["packages/react-components/react-select/src/index.ts"],
Expand Down
14 changes: 7 additions & 7 deletions workspace.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,13 @@
"projectType": "library",
"implicitDependencies": []
},
"@fluentui/react-overflow": {
"root": "packages/react-overflow",
"projectType": "library",
"implicitDependencies": [],
"sourceRoot": "packages/react-overflow/src",
"tags": ["vNext", "platform:web"]
},
"@fluentui/react-popover": {
"root": "packages/react-components/react-popover",
"projectType": "library",
Expand Down Expand Up @@ -536,13 +543,6 @@
"tags": ["vNext", "platform:web"],
"implicitDependencies": []
},
"@fluentui/react-overflow": {
"root": "packages/react-overflow",
"projectType": "library",
"implicitDependencies": [],
"sourceRoot": "packages/react-overflow/src",
"tags": ["vNext", "platform:web"]
},
"@fluentui/react-proptypes": {
"root": "packages/fluentui/react-proptypes",
"projectType": "library",
Expand Down