-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore(react-utilities): add Slot mapped type tests #22638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(react-utilities): add Slot mapped type tests #22638
Conversation
| const noChildrenEl: ChildrenLessIntrinsicElement = { children: React.createElement('div', 'hello') }; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore - FIX THE API / this doesn't work ATM and should be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
one issue I exposed is that basically slot props cannot be required. is that expected behaviour ? |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7397104:
|
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 350 | 286 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 907 | 919 | 5000 | |
| Button | mount | 545 | 552 | 5000 | |
| FluentProvider | mount | 1968 | 2002 | 5000 | |
| FluentProviderWithTheme | mount | 303 | 262 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 234 | 235 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 350 | 286 | 10 | Possible regression |
| MakeStyles | mount | 1572 | 1550 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e45629a0978492d5a8a44934f5263e47862ac8b3 (build) |

Current Behavior
Slotis non trivial mapped type without any testing coverageNew Behavior
Slothas some type check tests coverageRelated Issue(s)
This also exposes issue found in #22633