Spin button/alternate appearances #22519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9c431c9:
|
Collaborator
📊 Bundle size report
🤖 This report was generated against 16a344ccb82318359a457f2071ff995c16869a2f |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 16a344ccb82318359a457f2071ff995c16869a2f (build) |
spmonahan
force-pushed
the
spin-button/alternate-appearances
branch
from
88a5425 to
fa9259f
Compare
micahgodbolt
approved these changes
Apr 18, 2022
Minor styling and story updates based on accessibility testing.
An update to the icons library version eliminates the need for these media queries as they are now handled by the icons themselves.
spmonahan
force-pushed
the
spin-button/alternate-appearances
branch
from
fa9259f to
9c431c9
Compare
Contributor
Author
Good catch! That is not correct. Fix pushed. |
khmakoto
approved these changes
Apr 19, 2022
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
* react-spinbutton: a11y updates Minor styling and story updates based on accessibility testing. * react-spinbutton: remove commented out TODOs * react-spinbutton: update styles for underline appearance * react-spinbutton: update styles for filledDarker appearance * react-spinbutton: update styles for filledLigther appearance * react-spinbutton: update high contrast button styles for underline appearance * react-spinbutton: remove windows high contrast media queries An update to the icons library version eliminates the need for these media queries as they are now handled by the icons themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should only be merged after #22489 is merged.
Current Behavior
The styles for the
underline,filledDarkerandfilledLighterappearances are not complete.New Behavior
The styles for the
underline,filledDarkerandfilledLighterappearances are complete.Related Issue(s)
#22307