-
Notifications
You must be signed in to change notification settings - Fork 2.9k
docs: setup github issues beta templates #22337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Hotell
merged 5 commits into
microsoft:master
from
Hotell:hotell/revamp-issue-templates
Apr 11, 2022
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0550a3e
docs: setup github issues beta templates
Hotell 020d96c
docs: deprecate old issue templates
Hotell fe52132
docs: setup github issues beta templates for feature request
Hotell 180f4de
fixup! docs: deprecate old issue templates
Hotell bbbacc3
Apply suggestions from code review
Hotell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| name: 🐞 Bug Report | ||
| description: File a bug report | ||
| title: '[Bug]: ' | ||
| labels: ['Type: Bug 🐛', 'Needs: Triage 🔍'] | ||
| assignees: [] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Thanks for taking the time to fill out this bug report! | ||
|
|
||
| - type: dropdown | ||
| id: lib-version | ||
| attributes: | ||
| label: Library | ||
| description: Which library is affected | ||
| options: | ||
| - React Northstar / v0 (@fluentui/react-northstar) | ||
| - React / v8 (@fluentui/react) | ||
| - React Components / v9 (@fluentui/react-components) | ||
| - Web Components (@fluentui/web-components) | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| id: env-info | ||
| attributes: | ||
| label: System Info | ||
| description: Output of `npx envinfo --system --npmPackages '{@fluent/*}' --browsers` | ||
| render: shell | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: dropdown | ||
| id: a11y-bug | ||
| attributes: | ||
| label: Are you reporting Accessibility issue? | ||
| description: | | ||
| **PLEASE NOTE:** | ||
|
|
||
| 1. Do not link to, screenshot or reference a Microsoft product in this description. | ||
| 2. Our screen reader support is limited to Edge + Narrator. | ||
| - Please check ARIA component examples to ensure it is not a screen reader or browser issue. | ||
| - Issues that do not reproduce in Edge + Narrator, and aren't caused by obvious invalid aria values, should be filed with the respective screen reading software, not the Fluent UI repo. | ||
| 3. There is documentation or best practice that supports your expected behavior (review [WAI-ARIA](https://www.w3.org/TR/wai-aria-1.1/) for accessibility guidance.) | ||
| options: | ||
| - 'yes' | ||
| - 'no' | ||
|
|
||
| - type: input | ||
| id: reproduction | ||
| attributes: | ||
| label: Reproduction | ||
| description: | | ||
| Please provide a link to one of following browser tools based on library version: | ||
| - React Northstar / v0 - https://codesandbox.io/s/fluent-ui-template-8ismt | ||
| - React / v8 - https://aka.ms/fluentpen | ||
| - React Components / v9 - https://codesandbox.io/ | ||
| - Web Components - https://codesandbox.io/ | ||
|
|
||
| Or a link to a repo that can reproduce the problem you ran into. | ||
|
|
||
| **NOTE:** | ||
|
|
||
| A [minimal reproduction](https://stackoverflow.com/help/minimal-reproducible-example) is required. | ||
| If a report is vague (e.g. just a generic error message) and has no reproduction, it will receive a "need reproduction" label. | ||
|
|
||
| If no reproduction is provided after 3 days, it will be auto-closed. | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| id: description | ||
| attributes: | ||
| label: Bug Description | ||
| value: | | ||
| ## Actual Behavior | ||
| fill this out | ||
|
|
||
| ## Expected Behavior | ||
| fill this out | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| id: logs | ||
| attributes: | ||
| label: Logs | ||
| description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks. | ||
| render: shell | ||
|
|
||
| - type: dropdown | ||
| id: request-priority | ||
| attributes: | ||
| label: Requested priority | ||
| options: | ||
| - Blocking | ||
| - High | ||
| - Normal | ||
| - Low | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: input | ||
| id: products-affected | ||
| attributes: | ||
| label: Products/sites affected | ||
| placeholder: (provide if applicable) | ||
|
|
||
| - type: dropdown | ||
| id: requested-help | ||
| attributes: | ||
| label: Are you willing to submit a PR to fix? | ||
| options: | ||
| - 'yes' | ||
| - 'no' | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: checkboxes | ||
| id: checkboxes | ||
| attributes: | ||
| label: Validations | ||
| description: Before submitting the issue, please make sure you do the following | ||
| options: | ||
| - label: Check that there isn't already an issue that reports the same bug to avoid creating a duplicate. | ||
| required: true | ||
| - label: The provided reproduction is a minimal reproducible example of the bug. | ||
| required: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| --- | ||
| name: Bug report | ||
| name: Bug report (Deprecated) | ||
| about: Found a bug in Fluent UI React? | ||
| --- | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| blank_issues_enabled: true | ||
| contact_links: | ||
| - name: Questions & Discussions | ||
| url: https://github.com/microsoft/fluentui/discussions | ||
| about: Use GitHub discussions for message-board style questions and discussions. | ||
| - name: Questions via Stack Overflow | ||
| url: https://stackoverflow.com/questions/tagged/fluentui | ||
| about: Please use Stack Overflow for questions `#fluentui-react`, `#fluentui` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| name: "\U0001F680 New feature proposal" | ||
| description: Propose a new feature to be added to Fluent UI | ||
| title: '[Feature]: ' | ||
| labels: ['Type: Feature', 'Needs: Triage 🔍'] | ||
| assignees: [] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Thanks for your interest in the project and taking the time to fill out this feature report! | ||
|
|
||
| - type: dropdown | ||
| id: lib-version | ||
| attributes: | ||
| label: Library | ||
| description: To which library would this be added to | ||
| options: | ||
| - React Northstar / v0 (@fluentui/react-northstar) | ||
| - React / v8 (@fluentui/react) | ||
| - React Components / v9 (@fluentui/react-components) | ||
| - Web Components (@fluentui/web-components) | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: textarea | ||
| id: feature-description | ||
| attributes: | ||
| label: Describe the feature that you would like added | ||
| validations: | ||
| required: true | ||
|
|
||
| - type: input | ||
| id: feature-discussed-with | ||
| attributes: | ||
| label: Have you discussed this feature with our team | ||
| description: Please use particular person or team github handle | ||
| validations: | ||
| required: false | ||
|
|
||
| - type: textarea | ||
| id: additional-context | ||
| attributes: | ||
| label: Additional context | ||
| description: Any other context or screenshots about the feature request here. | ||
| validations: | ||
| required: false | ||
|
|
||
| - type: checkboxes | ||
| id: checkboxes | ||
| attributes: | ||
| label: Validations | ||
| description: Before submitting the issue, please make sure you do the following | ||
| options: | ||
| - label: Check that there isn't already an issue that request the same feature to avoid creating a duplicate. | ||
| required: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked briefly with @jurokapsiar and it's not true for Northstar.
I don't know exact requirements, but it's probably not true for v9, too (manual accessibility reviews include screen readers, for example #22345).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's good to know! - I copied the wording from existing template and reduced it to have more succinct wording. Let's improve this as follow-up WDYT ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me 👍