Skip to content

fix(Calendar): re-remove aria-readonly on grid cells #21374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecraig12345 merged 2 commits into from
Jan 21, 2022
Merged

fix(Calendar): re-remove aria-readonly on grid cells #21374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
847b4f3
fix aria-readonly regression on Calendar
smhigley Jan 21, 2022
7e1f53e
Change files
smhigley Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-98c7b050-b677-41f4-8303-36efc8bbfee7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Fix aria-readonly regression in Calendar",
"packageName": "@fluentui/react",
"email": "[email protected]",
"dependentChangeType": "patch"
}
1 change: 0 additions & 1 deletion packages/react/src/components/CalendarDayGrid/CalendarGridDayCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ export const CalendarGridDayCell: React.FunctionComponent<ICalendarGridDayCellPr
onKeyDown={!ariaHidden ? onDayKeyDown : undefined}
role="gridcell"
tabIndex={isNavigatedDate ? 0 : undefined}
aria-readonly="true"
aria-current={day.isSelected ? 'date' : undefined}
aria-selected={day.isInBounds ? day.isSelected : undefined}
data-is-focusable={!ariaHidden && (allFocusable || (day.isInBounds ? true : undefined))}
Expand Down
42 changes: 0 additions & 42 deletions packages/react/src/components/WeeklyDayPicker/__snapshots__/WeeklyDayPicker.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -707,7 +706,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -821,7 +819,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -935,7 +932,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1049,7 +1045,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1163,7 +1158,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1277,7 +1271,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1396,7 +1389,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1538,7 +1530,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1680,7 +1671,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1822,7 +1812,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -1965,7 +1954,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-current="date"
aria-disabled={false}
aria-readonly="true"
aria-selected={true}
className=
ms-CalendarDay-daySelected
Expand Down Expand Up @@ -2157,7 +2145,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -2295,7 +2282,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -2449,7 +2435,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -2559,7 +2544,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -2669,7 +2653,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -2779,7 +2762,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -2889,7 +2871,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -2999,7 +2980,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -3109,7 +3089,6 @@ exports[`WeeklyDayPicker renders WeeklyDayPicker with FirstDayOfWeek=Wednesday c
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -3907,7 +3886,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4021,7 +3999,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4135,7 +4112,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4249,7 +4225,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4363,7 +4338,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4477,7 +4451,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4591,7 +4564,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4710,7 +4682,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4852,7 +4823,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -4995,7 +4965,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-current="date"
aria-disabled={false}
aria-readonly="true"
aria-selected={true}
className=
ms-CalendarDay-daySelected
Expand Down Expand Up @@ -5187,7 +5156,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -5325,7 +5293,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -5463,7 +5430,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -5601,7 +5567,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
</td>
<td
aria-disabled={false}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -5755,7 +5720,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -5865,7 +5829,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -5975,7 +5938,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -6085,7 +6047,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -6195,7 +6156,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -6305,7 +6265,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down Expand Up @@ -6415,7 +6374,6 @@ exports[`WeeklyDayPicker renders default WeeklyDayPicker correctly 1`] = `
<td
aria-disabled={false}
aria-hidden={true}
aria-readonly="true"
aria-selected={false}
className=

Expand Down