Enable no implicit any in the utilities package

packages/utilities/api/utilities.api.ts

@@ -1,3 +1,5 @@
+export function assign(target: any, ...args: any[]): any;
+
 // WARNING: dispose has incomplete type information
 // WARNING: clearImmediate has incomplete type information
 // WARNING: clearInterval has incomplete type information
@@ -50,10 +52,11 @@ class BaseComponent<P extends IBaseProps, S> extends React.Component<P, S> {
 
 // WARNING: contextTypes has incomplete type information
 // WARNING: childContextTypes has incomplete type information
-// WARNING: __constructor has incomplete type information
 // WARNING: componentWillReceiveProps has incomplete type information
 // WARNING: render has incomplete type information
 class Customizer extends BaseComponent<ICustomizerProps, ICustomizerState> {
+  // (undocumented)
+  constructor(props: any, context: any);
   public static addChangeListener(onChanged: IChangeListener): void;
   // (undocumented)
   public getChildContext(): any;
@@ -150,6 +153,8 @@ export function hasOverflow(element: HTMLElement): boolean;
 
 export function hasVerticalOverflow(element: HTMLElement): boolean;
 
+export function hoistMethods(destination: any, source: any, exclusions: string[] = REACT_LIFECYCLE_EXCLUSIONS): string[];
+
 // (undocumented)
 interface IBaseProps {
   // (undocumented)
@@ -374,10 +379,8 @@ export function warnMutuallyExclusive < P >(componentName: string,
 // WARNING: getWindow has incomplete type information
 // WARNING: getDocument has incomplete type information
 // WARNING: doesElementContainFocus has incomplete type information
-// WARNING: hoistMethods has incomplete type information
 // WARNING: setLanguage has incomplete type information
 // WARNING: shallowCompare has incomplete type information
-// WARNING: assign has incomplete type information
 // WARNING: filteredAssign has incomplete type information
 // WARNING: Unsupported export: baseElementEvents
 // WARNING: Unsupported export: baseElementProperties

packages/utilities/package.json

@@ -20,6 +20,7 @@
     "@types/chai": "^3.4.35",
     "@types/enzyme": "^2.7.5",
     "@types/es6-promise": "^0.0.32",
+    "@types/es6-weak-map": "1.2.0",
     "@types/mocha": "^2.2.39",
     "@types/prop-types": "^15.5.1",
     "@types/react": "^15.0.25",

packages/utilities/src/Async.ts

@@ -10,9 +10,9 @@ declare function setTimeout(cb: Function, delay: number): number;
 declare function setInterval(cb: Function, delay: number): number;
 
 export class Async {
-  private _timeoutIds = null;
-  private _immediateIds = null;
-  private _intervalIds = null;
+  private _timeoutIds: any = null;
+  private _immediateIds: any = null;
+  private _intervalIds: any = null;
   private _animationFrameIds: { [id: number]: boolean } = null;
   private _isDisposed = false;
   private _parent: any;
@@ -38,7 +38,7 @@ export class Async {
     if (this._timeoutIds) {
       for (id in this._timeoutIds) {
         if (this._timeoutIds.hasOwnProperty(id)) {
-          this.clearTimeout(id);
+          this.clearTimeout(parseInt(id, 10));
         }
       }
 
@@ -49,7 +49,7 @@ export class Async {
     if (this._immediateIds) {
       for (id in this._immediateIds) {
         if (this._immediateIds.hasOwnProperty(id)) {
-          this.clearImmediate(id);
+          this.clearImmediate(parseInt(id, 10));
         }
       }
 
@@ -60,7 +60,7 @@ export class Async {
     if (this._intervalIds) {
       for (id in this._intervalIds) {
         if (this._intervalIds.hasOwnProperty(id)) {
-          this.clearInterval(id);
+          this.clearInterval(parseInt(id, 10));
         }
       }
       this._intervalIds = null;
@@ -70,7 +70,7 @@ export class Async {
     if (this._animationFrameIds) {
       for (id in this._animationFrameIds) {
         if (this._animationFrameIds.hasOwnProperty(id)) {
-          this.cancelAnimationFrame(id);
+          this.cancelAnimationFrame(parseInt(id, 10));
         }
       }
 
@@ -254,7 +254,7 @@ export class Async {
     let leading = true;
     let trailing = true;
     let lastExecuteTime = 0;
-    let lastResult;
+    let lastResult: any;
     let lastArgs: any[];
     let timeoutId: number = null;
 
@@ -320,10 +320,10 @@ export class Async {
     let waitMS = wait || 0;
     let leading = false;
     let trailing = true;
-    let maxWait = null;
+    let maxWait: any = null;
     let lastCallTime = 0;
     let lastExecuteTime = (new Date).getTime();
-    let lastResult;
+    let lastResult: any;
     let lastArgs: any[];
     let timeoutId: number = null;
 

packages/utilities/src/BaseComponent.test.tsx

@@ -85,15 +85,15 @@ describe('BaseComponent', () => {
   });
 });
 
-function _buildTestFor(methodName) {
+function _buildTestFor(methodName: string) {
   it(`calls the error logger on ${methodName} exception`, () => {
     let lastErrorMessage = null;
 
     BaseComponent.onError = (errorMessage, ex) => lastErrorMessage = errorMessage;
 
     let c = new TestComponent();
 
-    c[methodName]();
+    (c as any)[methodName]();
 
     assert(lastErrorMessage !== null, 'Error callback not called');
   });

packages/utilities/src/BaseComponent.ts

@@ -146,7 +146,7 @@ export class BaseComponent<P extends IBaseProps, S> extends React.Component<P, S
     }
     if (!this.__resolves[refName]) {
       this.__resolves[refName] = (ref) => {
-        return this[refName] = ref;
+        return (this as any)[refName] = ref;
       };
     }
 
@@ -202,11 +202,11 @@ function _makeAllSafe(obj: BaseComponent<any, any>, prototype: Object, methodNam
 }
 
 function _makeSafe(obj: BaseComponent<any, any>, prototype: Object, methodName: string) {
-  let classMethod = obj[methodName];
-  let prototypeMethod = prototype[methodName];
+  let classMethod = (obj as any)[methodName];
+  let prototypeMethod = (prototype as any)[methodName];
 
   if (classMethod || prototypeMethod) {
-    obj[methodName] = function () {
+    (obj as any)[methodName] = function () {
       let retVal;
 
       try {

packages/utilities/src/Customizer.tsx

@@ -77,7 +77,7 @@ export class Customizer extends BaseComponent<ICustomizerProps, ICustomizerState
     }
   }
 
-  constructor(props, context) {
+  constructor(props: any, context: any) {
     super(props);
 
     this.state = this._getInjectedProps(props, context);
@@ -87,7 +87,7 @@ export class Customizer extends BaseComponent<ICustomizerProps, ICustomizerState
     return this.state;
   }
 
-  public componentWillReceiveProps(newProps, newContext) {
+  public componentWillReceiveProps(newProps: any, newContext: any) {
     this.setState(this._getInjectedProps(newProps, newContext));
   }
 

packages/utilities/src/DelayedRender.tsx

@@ -24,7 +24,7 @@ export class DelayedRender extends React.Component<IDelayedRenderProps, IDelayed
     delay: 0
   };
 
-  private _timeoutId;
+  private _timeoutId: number | undefined;
 
   constructor(props: IDelayedRenderProps) {
     super(props);

packages/utilities/src/EventGroup.ts

@@ -33,7 +33,7 @@ export interface IDeclaredEventsByName {
  */
 export class EventGroup {
   private static _uniqueId = 0;
-  private _parent;
+  private _parent: any;
   private _eventRecords: IEventRecord[];
   private _id = EventGroup._uniqueId++;
   private _isDisposed: boolean;
@@ -56,10 +56,10 @@ export class EventGroup {
         let ev = document.createEvent('HTMLEvents');
 
         ev.initEvent(eventName, bubbleEvent, true);
-        ev['args'] = eventArgs;
+        (ev as any)['args'] = eventArgs;
         retVal = target.dispatchEvent(ev);
-      } else if (document['createEventObject']) { // IE8
-        let evObj = document['createEventObject'](eventArgs);
+      } else if ((document as any)['createEventObject']) { // IE8
+        let evObj = (document as any)['createEventObject'](eventArgs);
         // cannot set cancelBubble on evObj, fireEvent will overwrite it
         target.fireEvent('on' + eventName, evObj);
       }

packages/utilities/src/autobind.ts

@@ -30,7 +30,7 @@ export function autobind<T extends Function>(target: any, key: string, descripto
       return fnBound;
     },
 
-    set(newValue) {
+    set(newValue: any) {
       Object.defineProperty(this, key, {
         configurable: true,
         writable: true,

packages/utilities/src/css.ts

@@ -20,7 +20,7 @@ export function css(...args: ICssInput[]) {
         classes.push(arg.toString());
       } else {
         for (let key in arg as any) {
-          if (arg[key]) {
+          if ((arg as any)[key]) {
             classes.push(key);
           }
         }

packages/utilities/src/customizable.test.tsx

@@ -10,7 +10,7 @@ class Foo extends React.Component<{ field: string; }, {}> {
   public name: any;
 
   public render() {
-    return <div>{ this.props[this.props.field] }</div>;
+    return <div>{ (this.props as any)[this.props.field] }</div>;
   }
 }
 

packages/utilities/src/customizable.tsx

@@ -29,7 +29,7 @@ export function customizable<P>(fields: string[]) {
         let defaultProps = {};
 
         for (let propName of fields) {
-          defaultProps[propName] = (this.context.injectedProps) ?
+          (defaultProps as any)[propName] = (this.context.injectedProps) ?
             this.context.injectedProps[propName] :
             Customizer.getDefault(propName);
         }

packages/utilities/src/dom.ts

@@ -106,7 +106,7 @@ let _isSSR = false;
 /**
  * Helper to set ssr mode to simulate no window object returned from getWindow helper.
  */
-export function setSSR(isEnabled) {
+export function setSSR(isEnabled: boolean) {
   _isSSR = isEnabled;
 }
 

packages/utilities/src/focus.test.tsx

@@ -8,9 +8,9 @@ let { expect } = chai;
 
 import { isElementVisible, isElementTabbable } from './focus';
 
-let _hiddenElement;
-let _visibleElement;
-let _element;
+let _hiddenElement: HTMLElement | undefined;
+let _visibleElement: HTMLElement | undefined;
+let _element: HTMLElement | undefined;
 
 function renderIntoDocument(element: React.ReactElement<any>): HTMLElement {
   const component = ReactTestUtils.renderIntoDocument(element);

packages/utilities/src/hoist.ts

@@ -18,7 +18,7 @@ const REACT_LIFECYCLE_EXCLUSIONS = [
  * @param exclusions - (Optional) What methods to exclude from being hoisted.
  * @returns An array of names of methods that were hoisted.
  */
-export function hoistMethods(destination, source, exclusions: string[] = REACT_LIFECYCLE_EXCLUSIONS): string[] {
+export function hoistMethods(destination: any, source: any, exclusions: string[] = REACT_LIFECYCLE_EXCLUSIONS): string[] {
   let hoisted: string[] = [];
   for (let methodName in source) {
     if (

packages/utilities/src/memoize.test.ts

@@ -1,10 +1,10 @@
 import { memoize, memoizeFunction, setMemoizeWeakMap } from './memoize';
-import * as weakMapPolyfill from 'es6-weak-map/polyfill';
+import weakMapPolyfill = require('es6-weak-map');
 
 let { expect } = chai;
 
 describe('memoizeFunction', () => {
-  before(()=> {
+  before(() => {
     setMemoizeWeakMap(weakMapPolyfill);
   });
 
@@ -95,7 +95,7 @@ describe('memoizeFunction', () => {
 });
 
 describe('memoize', () => {
-  before(()=> {
+  before(() => {
     setMemoizeWeakMap(weakMapPolyfill);
   });