Skip to content

With responsive mode error #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
Jun 12, 2017
Merged

With responsive mode error #1956

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
470ceaf
withResponsiveMode: Adding error handling around the case where windo…
Jun 8, 2017
2b5e70e
adding change log file
Jun 8, 2017
9169c53
Create withResponsiveMode.tsx
dzearing Jun 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/withResponsiveModeError_2017-06-08-12-44.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "withResponsiveMode: Adding error handling around the case where window.innerWidth throws an exception.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "admitt@microsoft.com"
}
8 changes: 6 additions & 2 deletions packages/office-ui-fabric-react/src/utilities/decorators/withResponsiveMode.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,12 @@ export function withResponsiveMode<P extends { responsiveMode?: ResponsiveMode }
let win = getWindow();

if (typeof win !== 'undefined') {
while (win.innerWidth > RESPONSIVE_MAX_CONSTRAINT[responsiveMode]) {
responsiveMode++;
try {
while (win.innerWidth > RESPONSIVE_MAX_CONSTRAINT[responsiveMode]) {
responsiveMode++;
}
} catch (e) {
responsiveMode = undefined;

@dzearing dzearing Jun 12, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you should fall back to _defaultMode. Returning undefined is unexpected, given it doesn't map to any enum value.

}
} else {
if (_defaultMode !== undefined) {
Expand Down