Skip to content

Cypress timeouts dialog fix #17483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ling1726 merged 3 commits into from
Mar 18, 2021
Merged

Cypress timeouts dialog fix #17483

ling1726 merged 3 commits into from
Mar 18, 2021

Conversation

@vejrj
Copy link
Contributor

@vejrj vejrj commented Mar 18, 2021

Description of changes

Dialog E2E tests were temporarily fixed with wait functions.

Focus areas to test

Fluent UI E2E tests

@msft-fluent-ui-bot msft-fluent-ui-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Mar 18, 2021
ling1726
ling1726 reviewed Mar 18, 2021
View reviewed changes
@DustyTheBot
Copy link

DustyTheBot commented Mar 18, 2021 •
edited
Loading

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against cc1592d

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 18, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cc1592d:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@vejrj
Copy link
Contributor Author

vejrj commented Mar 18, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 18, 2021

Azure Pipelines successfully started running 3 pipeline(s).

@size-auditor
Copy link

size-auditor bot commented Mar 18, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 227755f22f8a6b5a9fd0549304fd8625ce927fd4 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 18, 2021 •
edited
Loading

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1164 1168 5000
BaseButton mount 947 944 5000
Breadcrumb mount 42291 42104 5000
ButtonNext mount 1338 1326 5000
Checkbox mount 1612 1581 5000
CheckboxBase mount 1350 1397 5000
ChoiceGroup mount 5063 4965 5000
ComboBox mount 1021 1012 1000
CommandBar mount 10058 10089 1000
ContextualMenu mount 6411 6278 1000
DefaultButton mount 1160 1150 5000
DetailsRow mount 3710 3671 5000
DetailsRowFast mount 3925 3688 5000
DetailsRowNoStyles mount 3528 3518 5000
Dialog mount 1501 1470 1000
DocumentCardTitle mount 1894 1824 1000
Dropdown mount 3548 3470 5000
FocusTrapZone mount 1914 1888 5000
FocusZone mount 1812 1844 5000
IconButton mount 1869 1862 5000
Label mount 362 370 5000
Layer mount 1991 2007 5000
Link mount 487 499 5000
MakeStyles mount 1996 1933 50000
MenuButton mount 1590 1573 5000
MessageBar mount 2054 2298 5000
Nav mount 3591 3411 1000
OverflowSet mount 1117 1070 5000
Panel mount 1465 1429 1000
Persona mount 863 824 1000
Pivot mount 1487 1456 1000
PrimaryButton mount 1310 1374 5000
Rating mount 8068 8191 5000
SearchBox mount 1407 1434 5000
Shimmer mount 2729 2727 5000
Slider mount 2167 2055 5000
SpinButton mount 5081 5194 5000
Spinner mount 432 427 5000
SplitButton mount 3235 3209 5000
Stack mount 523 531 5000
StackWithIntrinsicChildren mount 1704 1697 5000
StackWithTextChildren mount 4943 4881 5000
SwatchColorPicker mount 10557 10692 5000
Tabs mount 1459 1392 1000
TagPicker mount 2838 2892 5000
TeachingBubble mount 11676 11768 5000
Text mount 436 445 5000
TextField mount 1399 1415 5000
ThemeProvider mount 1180 1172 5000
ThemeProvider virtual-rerender 596 606 5000
ThemeProviderNext mount 15302 15313 5000
Toggle mount 853 850 5000
buttonNative mount 111 115 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.19 0.49 0.39:1 2000 382
🦄 Button.Fluent 0.13 0.21 0.62:1 5000 641
🔧 Checkbox.Fluent 0.7 0.38 1.84:1 1000 696
🎯 Dialog.Fluent 0.17 0.23 0.74:1 5000 864
🔧 Dropdown.Fluent 3.23 0.43 7.51:1 1000 3228
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 721
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 450
🔧 Slider.Fluent 1.65 0.48 3.44:1 1000 1646
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 415
🦄 Tooltip.Fluent 0.16 0.9 0.18:1 5000 778

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ListCommonPerf.default 775 710 1.09:1
Tooltip.Fluent 778 712 1.09:1
ListWith60ListItems.default 714 661 1.08:1
TableMinimalPerf.default 491 458 1.07:1
AnimationMinimalPerf.default 456 432 1.06:1
IconMinimalPerf.default 781 745 1.05:1
VideoMinimalPerf.default 725 691 1.05:1
Avatar.Fluent 382 365 1.05:1
AvatarMinimalPerf.default 226 217 1.04:1
PopupMinimalPerf.default 772 744 1.04:1
RefMinimalPerf.default 246 236 1.04:1
Button.Fluent 641 615 1.04:1
DropdownManyItemsPerf.default 813 788 1.03:1
DropdownMinimalPerf.default 3240 3147 1.03:1
FlexMinimalPerf.default 361 349 1.03:1
ListMinimalPerf.default 583 566 1.03:1
SliderMinimalPerf.default 1666 1621 1.03:1
Dropdown.Fluent 3228 3149 1.03:1
Image.Fluent 450 435 1.03:1
AccordionMinimalPerf.default 185 181 1.02:1
BoxMinimalPerf.default 427 420 1.02:1
ButtonUseCssPerf.default 899 882 1.02:1
ChatMinimalPerf.default 697 682 1.02:1
CheckboxMinimalPerf.default 3002 2935 1.02:1
DividerMinimalPerf.default 435 427 1.02:1
HeaderSlotsPerf.default 887 869 1.02:1
LabelMinimalPerf.default 474 466 1.02:1
ListNestedPerf.default 650 637 1.02:1
MenuMinimalPerf.default 979 962 1.02:1
MenuButtonMinimalPerf.default 1727 1698 1.02:1
ProviderMergeThemesPerf.default 1640 1606 1.02:1
RadioGroupMinimalPerf.default 521 511 1.02:1
StatusMinimalPerf.default 822 808 1.02:1
CustomToolbarPrototype.default 3845 3766 1.02:1
CardMinimalPerf.default 623 616 1.01:1
CarouselMinimalPerf.default 515 510 1.01:1
EmbedMinimalPerf.default 4572 4508 1.01:1
HeaderMinimalPerf.default 426 423 1.01:1
InputMinimalPerf.default 1390 1371 1.01:1
LayoutMinimalPerf.default 473 468 1.01:1
TableManyItemsPerf.default 2245 2218 1.01:1
TextAreaMinimalPerf.default 565 558 1.01:1
ToolbarMinimalPerf.default 1064 1051 1.01:1
Checkbox.Fluent 696 686 1.01:1
Dialog.Fluent 864 855 1.01:1
Slider.Fluent 1646 1636 1.01:1
AlertMinimalPerf.default 328 328 1:1
AttachmentMinimalPerf.default 195 195 1:1
AttachmentSlotsPerf.default 1274 1269 1:1
ButtonOverridesMissPerf.default 1779 1784 1:1
DatepickerMinimalPerf.default 48695 48468 1:1
DialogMinimalPerf.default 834 832 1:1
FormMinimalPerf.default 478 478 1:1
ImageMinimalPerf.default 443 442 1:1
SplitButtonMinimalPerf.default 4018 4034 1:1
TreeMinimalPerf.default 876 876 1:1
Text.Fluent 415 414 1:1
ButtonMinimalPerf.default 206 209 0.99:1
ButtonSlotsPerf.default 620 628 0.99:1
ButtonUseCssNestingPerf.default 1142 1148 0.99:1
TextMinimalPerf.default 397 403 0.99:1
Icon.Fluent 721 727 0.99:1
ChatDuplicateMessagesPerf.default 322 330 0.98:1
ChatWithPopoverPerf.default 415 422 0.98:1
GridMinimalPerf.default 401 410 0.98:1
ItemLayoutMinimalPerf.default 1346 1372 0.98:1
LoaderMinimalPerf.default 760 775 0.98:1
RosterPerf.default 1262 1287 0.98:1
SegmentMinimalPerf.default 401 410 0.98:1
TreeWith60ListItems.default 200 205 0.98:1
SkeletonMinimalPerf.default 415 427 0.97:1
ProviderMinimalPerf.default 1001 1057 0.95:1
TooltipMinimalPerf.default 1029 1091 0.94:1
PortalMinimalPerf.default 171 184 0.93:1
ReactionMinimalPerf.default 444 479 0.93:1

layershifter
layershifter reviewed Mar 18, 2021
View reviewed changes
@vejrj vejrj enabled auto-merge (squash) March 18, 2021 12:05
@vejrj vejrj closed this Mar 18, 2021
auto-merge was automatically disabled March 18, 2021 13:44

Pull request was closed

@vejrj vejrj reopened this Mar 18, 2021
@vejrj vejrj enabled auto-merge (squash) March 18, 2021 15:25
@vejrj vejrj force-pushed the vejrj/cypress-timeouts-fix-v2 branch from ea0d4a6 to cc1592d Compare March 18, 2021 15:45
@vejrj vejrj disabled auto-merge March 18, 2021 16:39
@vejrj vejrj closed this Mar 18, 2021
@vejrj vejrj reopened this Mar 18, 2021
@vejrj vejrj closed this Mar 18, 2021
@vejrj vejrj reopened this Mar 18, 2021
@vejrj vejrj closed this Mar 18, 2021
@vejrj vejrj reopened this Mar 18, 2021
@ling1726 ling1726 merged commit 124043a into microsoft:master Mar 18, 2021
joshualamusga1 pushed a commit to joshualamusga1/fluentui that referenced this pull request Mar 25, 2021
@vejrj @joshualamusga1
Cypress timeouts dialog fix (microsoft#17483)
b0e49a1 
* Cypress timeouts dialog fix

* Revert "Cypress timeouts dialog fix"

This reverts commit 18d2643.

* dialogs excluded
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request May 5, 2021
@vejrj @miroslavstastny
Cypress timeouts dialog fix (microsoft#17483)
6197de6 
* Cypress timeouts dialog fix

* Revert "Cypress timeouts dialog fix"

This reverts commit 18d2643.

* dialogs excluded
This was referenced May 5, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layershifter layershifter layershifter approved these changes

@assuncaocharles assuncaocharles Awaiting requested review from assuncaocharles

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar

@miroslavstastny miroslavstastny Awaiting requested review from miroslavstastny

@pompomon pompomon Awaiting requested review from pompomon

+1 more reviewer

@ling1726 ling1726 ling1726 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@khmakoto khmakoto

Labels

Fluent UI react-northstar (v0) Work related to Fluent UI V0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vejrj @DustyTheBot @fabricteam @layershifter @ling1726 @khmakoto @msft-fluent-ui-bot