Skip to content

Fixed persona size 28 initials size #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micahgodbolt merged 5 commits into from
May 4, 2017
Merged

Fixed persona size 28 initials size #1715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2093179
Fixed persona size 28 initials size
lju May 4, 2017
67bdfc8
Merge branch 'master' into master
lju May 4, 2017
ae9ba48
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
lju May 4, 2017
9ca6b0d
Rush change file
lju May 4, 2017
5c95ba2
Merge branch 'master' of https://github.com/lju/office-ui-fabric-react
lju May 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/lydutk-fixedPersonaSize28InitialsHeight_2017-05-04-15-28.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Fixed Persona size28 height of initials",
Copy link
Copy Markdown
Contributor

@MLoughry MLoughry May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The standard way of phrasing this is ": ". Also, it's included directly in the release notes, so I'd have it describe the change in behavior, rather than the change in code. A possible comment:

Persona: Fixed clipping issue when using size28.

"type": "patch"
}
],
"email": "lydutk@microsoft.com"
}
4 changes: 2 additions & 2 deletions packages/office-ui-fabric-react/src/components/Persona/Persona.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,8 +399,8 @@ $ms-Persona-presenceSizeXl: 28px;

.initials {
font-size: $ms-font-size-xs;
height: $ms-Persona-sizeXxs;
line-height: $ms-Persona-sizeXxs;
height: $ms-Persona-size28;
line-height: $ms-Persona-size28;
}

.presence {
Expand Down