Skip to content

SearchBox: added the ariaLabel optional property #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micahgodbolt merged 2 commits into from
May 5, 2017
Merged

SearchBox: added the ariaLabel optional property #1689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a33801d
SearchBox: added the ariaLabel optional property
May 3, 2017
529c5ed
Merge branch 'master' into searchbox-aria-label
micahgodbolt May 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions common/changes/SearchBox-allow-aria-label_2017-05-04-06-49.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "SearchBox: added the ariaLabel optional property",
"type": "minor"
},
{
"comment": "",
"packageName": "@uifabric/utilities",
"type": "none"
}
],
"email": "jakob101@gmail.com"
}
6 changes: 6 additions & 0 deletions packages/office-ui-fabric-react/src/components/SearchBox/SearchBox.Props.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,10 @@ export interface ISearchBoxProps extends React.Props<SearchBox> {
* CSS class to apply to the SearchBox.
*/
className?: string;

/**
* The aria label of the SearchBox for the benefit of screen readers.
* @defaultvalue labelText
*/
ariaLabel?: string;
}
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/SearchBox/SearchBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ export class SearchBox extends BaseComponent<ISearchBoxProps, ISearchBoxState> {
onInput={ this._onInputChange }
onKeyDown={ this._onKeyDown }
value={ value }
aria-label={ this.props.ariaLabel ? this.props.ariaLabel : this.props.labelText }
ref={ this._resolveRef('_inputElement') }
/>
<div
Expand Down