Skip to content

Modal: Fixed bug where props/state were passed in reverse order #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 2 commits into from
May 2, 2017
Merged

Modal: Fixed bug where props/state were passed in reverse order #1679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dae8933
Fixed bug where props/state were passed in reverse order
micahgodbolt May 2, 2017
70483a8
Add change file
micahgodbolt May 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/modal-bug-fix_2017-05-02-17-16.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Modal: Fixed bug where props and state were passed in reversed order",
"type": "patch"
}
],
"email": "micahgodbolt@gmail.com"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/Modal/Modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export class Modal extends BaseComponent<IModalProps, IDialogState> {
}
}

public componentDidUpdate(prevState: IDialogState, prevProps: IModalProps) {
public componentDidUpdate(prevProps: IModalProps, prevState: IDialogState) {
if (!prevProps.isOpen && !prevState.isVisible) {
this.setState({
isVisible: true
Expand Down