Skip to content

Add tooltip class name #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cschleiden merged 3 commits into from
May 2, 2017
Merged

Add tooltip class name #1675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c766b5e
TooltipHost: Add className and fix example button
hross May 2, 2017
cc9a86b
Merge branch 'master' into add-tooltip-className
cschleiden May 2, 2017
132092e
Merge branch 'master' into add-tooltip-className
cschleiden May 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/add-tooltip-className_2017-05-02-10-28.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "TooltipHost: Add host className",
"type": "patch"
}
],
"email": "hross@hross.net"
}
5 changes: 5 additions & 0 deletions packages/office-ui-fabric-react/src/components/Tooltip/TooltipHost.Props.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,9 @@ export interface ITooltipHostProps extends React.HTMLProps<HTMLDivElement | Tool
* It also uses the parent as target element for the tooltip.
*/
overflowMode?: TooltipOverflowMode;

/**
* Optional class name to apply to tooltip host.
*/
hostClassName?: string;
Copy link
Copy Markdown
Member

@dzearing dzearing May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this just be className

Copy link
Copy Markdown
Contributor

@cschleiden cschleiden May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzearing className is passed through to the tooltip

}
4 changes: 2 additions & 2 deletions packages/office-ui-fabric-react/src/components/Tooltip/TooltipHost.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,12 @@ export class TooltipHost extends BaseComponent<ITooltipHostProps, ITooltipHostSt

// Render
public render() {
const { calloutProps, content, children, directionalHint, delay, id } = this.props;
const { calloutProps, content, children, directionalHint, delay, id, hostClassName } = this.props;
const { isTooltipVisible } = this.state;
const tooltipId = id || getId('tooltip');
return (
<div
className={ css('ms-TooltipHost', styles.host) }
className={ css('ms-TooltipHost', styles.host, hostClassName) }
ref={ this._resolveRef('_tooltipHost') }
{ ...{ onFocusCapture: this._onTooltipMouseEnter } }
{ ...{ onBlurCapture: this._onTooltipMouseLeave } }
Expand Down
4 changes: 2 additions & 2 deletions packages/office-ui-fabric-react/src/components/Tooltip/examples/Tooltip.Overflow.Example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import * as React from 'react';
/* tslint:enable:no-unused-variable */
import { BaseComponent, css } from 'office-ui-fabric-react/lib/Utilities';
import { Button } from 'office-ui-fabric-react/lib/Button';
import { DefaultButton } from 'office-ui-fabric-react/lib/Button';
import {
TooltipHost,
TooltipOverflowMode
Expand All @@ -20,7 +20,7 @@ export class TooltipOverflowExample extends BaseComponent<any, any> {
public render() {
return (
<div>
<Button onClick={ () => this.setState({ overflow: !this.state.overflow }) }>Toggle showing overflow</Button>
<DefaultButton onClick={ () => this.setState({ overflow: !this.state.overflow }) }>Toggle showing overflow</DefaultButton>

<div style={ {
marginTop: '40px'
Expand Down