Skip to content

#1664 -- Panel: Close button, size, margin and container. Updated to … #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
May 2, 2017
Merged

#1664 -- Panel: Close button, size, margin and container. Updated to … #1668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ff8a45
#1664 -- Panel: Close button, size, margin and container. Updated to …
aleksandrjPersonal May 1, 2017
0a5b0da
#1664 -- Rush Change
aleksandrjPersonal May 1, 2017
880f2cc
Update 1664_PanelCloseButton_2017-05-01-23-02.json
dzearing May 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/1664_PanelCloseButton_2017-05-01-23-02.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Panel: Updating the close button's height, container, margin, and size slightly.",
"type": "patch"
}
],
"email": "v-algemb@microsoft.com"
}
8 changes: 4 additions & 4 deletions packages/office-ui-fabric-react/src/components/Panel/Panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ $Panel-width-lg: 940px;
$Panel-margin-md: 48px;
$Panel-margin-lg: 428px;
$Panel-margin-xl: 176px;
$CommandBarHeight: 40px;
$CommandBarHeight: 44px;

.root {
display: none;
Expand Down Expand Up @@ -193,18 +193,18 @@ $CommandBarHeight: 40px;
}
}

// The button in the top right (x)
// The button in the top right (x)
.closeButton {
@include button-reset();
position: absolute;
@include right(8px);
@include right(4px);
top: 0;
height: $CommandBarHeight;
width: $CommandBarHeight;
line-height: $CommandBarHeight;
padding: 0;
color: $ms-color-neutralSecondary;
font-size: $ms-icon-size-m;
font-size: $ms-icon-size-l;

&:hover {
color: $ms-color-neutralPrimary;
Expand Down