Skip to content

Fixing AMD dependency break introduced in 2.23.1. #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
Apr 28, 2017
Merged

Fixing AMD dependency break introduced in 2.23.1. #1656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5dbd86b
Fixing import.
dzearing Apr 28, 2017
0589d6d
Adding change file.
dzearing Apr 28, 2017
1b56c0a
Update tooltiphost-fix_2017-04-28-17-38.json
dzearing Apr 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/tooltiphost-fix_2017-04-28-17-38.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "TooltipHost: Fixing AMD import to pull getId from the Utilities AMD-friendly top-level import.",
"type": "patch"
}
],
"email": "dzearing@microsoft.com"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/Tooltip/TooltipHost.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
css,
divProperties,
getNativeProps,
getId,
assign,
hasOverflow
} from '../../Utilities';
Expand All @@ -16,7 +17,6 @@ import { TooltipDelay } from './Tooltip.Props';

import * as stylesImport from './TooltipHost.scss';
const styles: any = stylesImport;
import { getId } from '@uifabric/utilities';

export interface ITooltipHostState {
isTooltipVisible?: boolean;
Expand Down