Skip to content

Use ariaLabel in Panel and fix up/down keyboard nav for links in Deta… #1645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cschleiden merged 2 commits into from
Apr 27, 2017
Merged

Use ariaLabel in Panel and fix up/down keyboard nav for links in Deta… #1645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fd61e0
Use ariaLabel in Panel and fix up/down keyboard nav for links in Deta…
dmarcey Apr 27, 2017
4331bf3
Merge branch 'master' into users/demarcey/bug1642
cschleiden Apr 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/Panel/Panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ export class Panel extends BaseComponent<IPanelProps, IPanelState> {
<IconButton
className={ css('ms-Panel-closeButton ms-PanelAction-close', styles.closeButton) }
onClick={ this._onPanelClick }
aria-label={ closeButtonAriaLabel }
ariaLabel={ closeButtonAriaLabel }
data-is-visible={ true }
iconProps={ { iconName: 'Cancel' } }
/>
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Panel/examples/Panel.SmallRight.Example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export class PanelSmallRightExample extends React.Component<any, any> {
type={ PanelType.smallFixedFar }
onDismiss={ this._onClosePanel }
headerText='Panel - Small, right-aligned, fixed, with footer'
closeButtonAriaLabel='Close'
onRenderFooterContent={ () => {
return (
<div>
Expand Down
3 changes: 2 additions & 1 deletion packages/office-ui-fabric-react/src/utilities/selection/SelectionZone.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,8 @@ export class SelectionZone extends BaseComponent<ISelectionZoneProps, {}> {
// For toggle elements, assuming they are rendered as buttons, they will generate a click event,
// so we can no-op for any keydowns in this case.
break;
} else if (target.tagName === 'BUTTON' || target.tagName === 'A' || target.tagName === 'INPUT') {
} else if ((ev.which === KeyCodes.enter || ev.which === KeyCodes.space) &&
(target.tagName === 'BUTTON' || target.tagName === 'A' || target.tagName === 'INPUT')) {
return false;
} else if (target === itemRoot) {
if (ev.which === KeyCodes.enter) {
Expand Down