-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Regression Test: Tests updates #1644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 52 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
68f871c
trying
v-reja e837b2b
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
gitjain 820d93b
Delete try.ts
gitjain 70ca0b0
updates
gitjain 815332a
Merge branch 'master' of https://github.com/gitjain/office-ui-fabric-…
gitjain 7524e07
RegressionTests: Toggle Tests
gitjain 42807e3
REgression Test: test class
gitjain d793d1a
Regression Tests: Helper class
gitjain c3db083
RegressionTests: Class updates
gitjain 7593f8f
Regression Test: Helper Class updates
gitjain 078cc84
Regression Tests: helper class updates
gitjain e60be8c
Regression Tests: Test Helper class updates
gitjain ab42091
Regression Tests: Test Helper class updates
gitjain e0821b9
Regression Tests: Event function
gitjain 328db25
updates
gitjain 9b99326
Regression Tests: Test helper functions
gitjain ac92597
Regression Tests: Rush change
gitjain 2c400ca
Regression Tests: merge conflict updates
gitjain 0baa3a4
Regression Test: Helper function Updates
gitjain 7fc29f7
Regression Tests: linting error updates
gitjain 7037ad6
Regression Tests: Test helper class
v-reja 5d0dea8
Regression Tests: Test helper functions
v-reja 5b4ffb1
Regression Test: Test helper updates
v-reja 57fa7eb
Regression Test: Test helper updates
v-reja 027298f
Regression test: Test helper updates
v-reja 2953f0e
Regression Tes: test helper updates
v-reja 8a52375
Regression Tests: Dialog tests
v-reja 16d6bab
Regression Tests: Updates
v-reja 50edad2
Regression Test: Test updates.
v-reja d9517d4
Regression Test: Test udpates
v-reja adb8a2d
Regression Test: test updates
v-reja 2f3af7e
Regression test: test updates
v-reja 2dfabd2
Regression Test: test updates
v-reja c7fdab9
Regression Test: Test updates
v-reja 666fade
Regression Test: tests
v-reja 20956df
Regression Test: Tests updates
gitjain 8db5a4e
Regression Test: Tooltip test updates
gitjain 838de63
Merge branch 'master' into visualTests
micahgodbolt 8c763d4
Regression Test: Toggle Test
gitjain c11bdb0
Regression tests
gitjain eb40de2
Regression Tests
gitjain c8a39a4
REgression Tests
gitjain 29fcae1
Regression Tests
gitjain c0fd554
Merge branch 'visualTests' of https://github.com/gitjain/office-ui-fa…
gitjain c3dcc89
Regression Tests
gitjain 7e73e33
Update visualTests_2017-04-27-23-02.json
gitjain ca2ad86
Regression Tests
gitjain 5990650
Regression Tests
gitjain e58af9f
Regression Test
gitjain 04dcbb5
Regression Test document update
gitjain aff95d2
Regression Test document update
gitjain 75da63f
Merge branch 'master' into visualTests
micahgodbolt b31262c
Update Facepile.Props.ts
dzearing 2496b59
Update visualTests_2017-04-27-23-02.json
dzearing be5b45d
Merge branch 'master' into visualTests
dzearing 6469311
Merge branch 'master' into visualTests
micahgodbolt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "Regression Tests", | ||
| "type": "patch" | ||
| }, | ||
| { | ||
| "comment": "", | ||
| "packageName": "@uifabric/utilities", | ||
| "type": "none" | ||
| }, | ||
| { | ||
| "comment": "", | ||
| "packageName": "@uifabric/styling", | ||
| "type": "none" | ||
| }, | ||
| { | ||
| "comment": "", | ||
| "packageName": "@uifabric/example-app-base", | ||
| "type": "none" | ||
| } | ||
| ], | ||
| "email": "r33najain@gmail.com" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
packages/office-ui-fabric-react/src/components/Breadcrumb/Breadcrumb.visualtest.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { Casper } from '../../visualtest/PhantomCssInterface'; | ||
| import { baseUrl } from '../../common/VisualTest'; | ||
| import { defaultScreenshot, mouseMoveScreenshot, mouseDownScreenshot, mouseClickScreenshot, testRunner } from '../../visualtest/RunVisualTest'; | ||
| import { IRunVisualTest } from '../../visualtest/IRunVisualTest'; | ||
|
|
||
| declare var casper: Casper; | ||
| let componentIds: IRunVisualTest[] = []; | ||
|
|
||
| componentIds.push({ | ||
| selector: '.' + 'Breadcrumb', | ||
| fileName: 'breadcrumb', | ||
| imageSelector: '.' + 'Breadcrumb', | ||
|
|
||
| commands: [defaultScreenshot] | ||
| }); | ||
| componentIds.push({ | ||
| selector: '.' + 'ms-Breadcrumb-listItem', | ||
| fileName: 'breadcrumb', | ||
| imageSelector: '.' + 'Breadcrumb', | ||
| commands: [mouseMoveScreenshot, mouseDownScreenshot, mouseClickScreenshot] | ||
| }); | ||
|
|
||
| casper. | ||
| start(baseUrl + 'breadcrumb'). | ||
| then(() => { | ||
| testRunner(componentIds); | ||
| }); | ||
|
|
||
| casper.run(() => { casper.test.done(); }); |
23 changes: 23 additions & 0 deletions
23
packages/office-ui-fabric-react/src/components/Breadcrumb/BreadcrumbPage.visualtest.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { Breadcrumb } from './index'; | ||
|
|
||
| /* tslint:disable:no-unused-variable */ | ||
| import * as React from 'react'; | ||
| /* tslint:enable:no-unused-variable */ | ||
| export default class BreadcrumbVPage extends React.Component<any, any> { | ||
| public render() { | ||
| return <div style={ { width: '600px' } }> | ||
| <Breadcrumb | ||
| className='Breadcrumb' | ||
|
|
||
| items={ [ | ||
| { text: 'Files', 'key': 'Files' }, | ||
| { text: 'This is folder 1', 'key': 'f1', onClick: () => { return; } }, | ||
| { text: 'This is folder 2', 'key': 'f2', onClick: () => { return; } }, | ||
| { text: 'This is folder 3', 'key': 'f3', onClick: () => { return; } }, | ||
| { text: 'This is folder 4', 'key': 'f4', onClick: () => { return; } }, | ||
| { text: 'This is folder 5', 'key': 'f5', onClick: () => { return; } }, | ||
| ] } | ||
| maxDisplayedItems={ 3 } /> | ||
| </div>; | ||
| } | ||
| } |
79 changes: 79 additions & 0 deletions
79
packages/office-ui-fabric-react/src/components/Button/Button.visualtest.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import { Casper } from '../../visualtest/PhantomCssInterface'; | ||
| import { baseUrl } from '../../common/VisualTest'; | ||
| import { | ||
| defaultScreenshot, mouseMoveScreenshot, mouseDownScreenshot, | ||
| mouseClickScreenshot, testRunner, mouseSingleClickScreenshot | ||
| } from '../../visualtest/RunVisualTest'; | ||
| import { IRunVisualTest } from '../../visualtest/IRunVisualTest'; | ||
| declare var casper: Casper; | ||
| let componentIds: IRunVisualTest[] = []; | ||
|
|
||
| componentIds.push({ | ||
| selector: '#' + 'DefaultButton', | ||
| fileName: 'buttonDefault', | ||
| commands: [defaultScreenshot, mouseClickScreenshot, mouseDownScreenshot, mouseMoveScreenshot] | ||
| }); | ||
|
|
||
| componentIds.push({ | ||
| selector: '#' + 'DefaultButtonDisabled', | ||
| fileName: 'buttonDefaultDisabled', | ||
| commands: [defaultScreenshot] | ||
| }); | ||
| componentIds.push({ | ||
| selector: '#' + 'PrimaryButton', | ||
| fileName: 'buttonPrimary', | ||
| commands: [defaultScreenshot, mouseClickScreenshot, mouseDownScreenshot, mouseMoveScreenshot] | ||
|
|
||
| }); | ||
| componentIds.push({ | ||
| selector: '#' + 'PrimaryButtonDisabled', | ||
| fileName: 'buttonPrimaryDisabled', | ||
| commands: [defaultScreenshot] | ||
| }); | ||
|
|
||
| componentIds.push({ | ||
| selector: '#' + 'CommandButton', | ||
| fileName: 'buttonCommand', | ||
| commands: [defaultScreenshot, mouseDownScreenshot, mouseMoveScreenshot, mouseClickScreenshot] | ||
| }); | ||
|
|
||
| componentIds.push({ | ||
| selector: '#' + 'CommandButtonDisabled', | ||
| fileName: 'buttonCommandDisabled', | ||
| commands: [defaultScreenshot] | ||
| }); | ||
|
|
||
| componentIds.push({ | ||
| selector: '#' + 'CompoundButton', | ||
| fileName: 'buttonCompound', | ||
| commands: [defaultScreenshot, mouseClickScreenshot, mouseDownScreenshot, mouseMoveScreenshot] | ||
| }); | ||
| componentIds.push({ | ||
| selector: '#' + 'CompoundButtonDisabled', | ||
| fileName: 'buttonCompoundDisabled', | ||
| commands: [defaultScreenshot] | ||
| }); | ||
| componentIds.push({ | ||
| selector: '#' + 'ContextualButton', | ||
| fileName: 'buttonContextual', | ||
| commands: [defaultScreenshot, mouseClickScreenshot, mouseDownScreenshot, mouseMoveScreenshot] | ||
| }); | ||
|
|
||
| componentIds.push({ | ||
| selector: '#' + 'ContextualButton', | ||
| fileName: 'buttonContextual', | ||
| commands: [mouseSingleClickScreenshot], | ||
| childParams: { | ||
| selector: '.' + 'ms-ContextualMenu-list', | ||
| fileName: 'buttonContextualMenu', | ||
| commands: [defaultScreenshot] | ||
| } | ||
| }); | ||
|
|
||
| casper. | ||
| start(baseUrl + 'button'). | ||
| then(() => { | ||
| testRunner(componentIds); | ||
| }); | ||
|
|
||
| casper.run(() => { casper.test.done(); }); |
73 changes: 73 additions & 0 deletions
73
packages/office-ui-fabric-react/src/components/Button/ButtonPage.visualtest.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| import { DefaultButton, IconButton, CommandButton, CompoundButton, PrimaryButton } from './index'; | ||
| import { IconName } from '../../Icon'; | ||
| /* tslint:disable:no-unused-variable */ | ||
| import * as React from 'react'; | ||
| /* tslint:enable:no-unused-variable */ | ||
| export default class ButtonVPage extends React.Component<any, any> { | ||
| public render() { | ||
| let iconName: IconName = 'Snow'; | ||
| return <div> | ||
| <div><label> Default Button: </label> | ||
| <DefaultButton id='DefaultButton' icon='Add' text='Default Button' /></div> | ||
| <div><label> Default Button Disabled: </label> | ||
| <DefaultButton id='DefaultButtonDisabled' disabled={ true } icon='Add' text='Default Button' /></div> | ||
| <div style={ { backgroundColor: 'white' } }> | ||
| <IconButton id={ 'IconButton' } iconProps={ { iconName } } /> | ||
| </div> | ||
| <div style={ { backgroundColor: 'white' } }> | ||
| <CommandButton id='CommandButton' | ||
| icon='AddFriend' | ||
| text='Command Button' /> | ||
| </div> | ||
| <div style={ { backgroundColor: 'white' } }> | ||
| <CommandButton id='CommandButtonDisabled' icon='AddFriend' | ||
| disabled={ true } | ||
| text='Command Button' /> | ||
| </div > | ||
| <div> | ||
| <CompoundButton id='CompoundButton' | ||
| description='You can create a new account here.' | ||
| text='Compound Button' /> | ||
| </div> | ||
| <div> | ||
| <CompoundButton id='CompoundButtonDisabled' | ||
| disabled={ true } | ||
| description='You can create a new account here.' | ||
| text='Compound Button' /> | ||
| </div> | ||
| <div> | ||
| <PrimaryButton id='PrimaryButton' icon='Add' text='Primary Button' /> | ||
| </div > | ||
| <div> | ||
| <PrimaryButton id='PrimaryButtonDisabled' disabled={ true } icon='Add' text='Primary Button' /> | ||
| </div > | ||
|
|
||
| <div> | ||
| <DefaultButton | ||
| id='ContextualButton' | ||
| disabled={ false } | ||
| icon='Add' | ||
| text='New' | ||
| menuProps={ { | ||
| className: 'ContextualButtonMenu', | ||
| id: 'ContextualButtonMenu', | ||
| items: [ | ||
| { | ||
| key: 'emailMessage', | ||
| name: 'Email message', | ||
| icon: 'Mail' | ||
| }, | ||
| { | ||
| key: 'calendarEvent', | ||
| name: 'Calendar event', | ||
| icon: 'Calendar' | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| > | ||
| </DefaultButton> | ||
| </div > | ||
| </div>; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to patch fabric-react for these changes, unless you're changing the product code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is change in Facepile props. Added ClassName.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then you comments in the change file should reflect it :) Otherwise we'll have a note in the release note that says "Regression Tests".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, adding classname is a minor bump, not a patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Thanks! So can we merge this PR?