Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (web components): inline start margin rtl slider #16356

Merged
merged 2 commits into from
Jan 5, 2021
Merged

fix (web components): inline start margin rtl slider #16356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ab44bb
add inline start margin for rtl to slider
Jan 4, 2021
3490ab0
Change files
Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...web-components-2021-01-04-11-29-21-users-v-sedono-fix-inline-start-margin-rtl-slider.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "patch",
"comment": "add inline start margin for rtl to slider",
"packageName": "@fluentui/web-components",
"email": "[email protected]",
"dependentChangeType": "patch",
"date": "2021-01-04T19:29:21.433Z"
}
2 changes: 1 addition & 1 deletion packages/web-components/src/slider/slider.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export const SliderStyles = css`
:host(.vertical) .track {
top: calc(var(--track-overhang) * 1px);
bottom: calc(var(--track-overhang) * 1px);
margin-left: calc((var(--design-unit) + calc(var(--density) + 2)) * 1px);
margin-inline-start: calc((var(--design-unit) + calc(var(--density) + 2)) * 1px);
width: calc(var(--track-width) * 1px);
height: 100%;
}
Expand Down