Skip to content

Panel left shadow #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikewheaton merged 4 commits into from
Apr 24, 2017
Merged

Panel left shadow #1586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a231396
Add proper shadow for left hand panel
micahgodbolt Apr 24, 2017
3008caf
Add change file
micahgodbolt Apr 24, 2017
80465b6
Merge branch 'master' into panel-left-shadow
micahgodbolt Apr 24, 2017
bd92045
Merge branch 'master' into panel-left-shadow
micahgodbolt Apr 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/panel-left-shadow_2017-04-24-16-26.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Panel: Fixed drop shadow for left side panel",
"type": "patch"
}
],
"email": "micahgodbolt@gmail.com"
}
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/Panel/Panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ $CommandBarHeight: 40px;
@include right(auto);
@include left(0);
width: $Panel-width-xs;
@include drop-shadow(30px, 0px, 30px, -30px, .2);
Copy link
Copy Markdown
Contributor

@mikewheaton mikewheaton Apr 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the ms-box-shadow() mixin here, and on line 71, for RTL support.

Copy link
Copy Markdown
Member Author

@micahgodbolt micahgodbolt Apr 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change both instances then

Copy link
Copy Markdown
Contributor

@mikewheaton mikewheaton Apr 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake, drop-shadow() is an RTL mixin already. :)

Copy link
Copy Markdown
Member Author

@micahgodbolt micahgodbolt Apr 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikewheaton not currently :)

@mixin drop-shadow($ms-x-offset: 0, $ms-y-offset: 0, $ms-blur: 5px, $ms-spread: 0, $ms-alpha: 0.4) {
  box-shadow: $ms-x-offset $ms-y-offset $ms-blur $ms-spread rgba(0, 0, 0, $ms-alpha);
}

Copy link
Copy Markdown
Member Author

@micahgodbolt micahgodbolt Apr 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pull this in. Looks like core 7.0 will bring in the required mixing. We can update it then.

}
}

Expand Down