Add semantic slots, starting with text fields#1568
Conversation
|
Looks fine to me (assuming no visual regressions). I've seen this approach before from @phkuo and it closely mirrors how I'd do it with external Theo tokens. I'm mostly curious how this would look using Glamor, though I don't feel anything here would make converting to Glamor harder. Maybe the bigger question is how close are we to converting to Glamor (pretty close I think), and should this work just be done in coordination with that glamor conversion. |
db1a99d to
2c36116
Compare
312b248 to
b90c9db
Compare
| // -------------------------------------------------- | ||
| // ChoiceField semantic slots | ||
|
|
||
| $radioButton-background-color: $controlBackgroundColor; |
There was a problem hiding this comment.
is a radio button any different from a checkbox?
There was a problem hiding this comment.
Unfortunately yes. For example, in the selected state, it uses a blue background and a white checkmark, whereas radio buttons have a white background and a blue dot.
|
Doing design review before completing this PR. |
|
@dzearing @micahgodbolt Could I get this reviewed and signed off please? |
|
@phkuo a few conflicts to resolve in textfield |
587039b to
a2c4e09
Compare
Pull request checklist
Description of changes
Lay some groundwork for converting to semantic slots, starting with input text fields.
Focus areas to test
(optional)