Skip to content

make focus async to get rid of sync focus in detailsList #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 12 commits into from
Apr 21, 2017
Merged

make focus async to get rid of sync focus in detailsList #1193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
aec48f0
make focus async to get rid of sync focus
jijizz Mar 6, 2017
9da9ba6
Merge branch 'master' into zhiliu/reduceFocusCost
micahgodbolt Mar 7, 2017
abe22bc
Merge branch 'master' into zhiliu/reduceFocusCost
micahgodbolt Mar 7, 2017
fcaf768
Merge branch 'master' into zhiliu/reduceFocusCost
micahgodbolt Mar 8, 2017
b2a57ba
Merge branch 'master' of git://github.com/OfficeDev/office-ui-fabric-…
jijizz Mar 29, 2017
d00a792
merge master
jijizz Apr 21, 2017
e8196ca
change back to setTimeout
jijizz Apr 21, 2017
3d3e4bf
Merge branch 'master' of git://github.com/OfficeDev/office-ui-fabric-…
jijizz Apr 21, 2017
c8fbce1
Merge branch 'zhiliu/reduceFocusCost' of https://github.com/jijizz/of…
jijizz Apr 21, 2017
7847ce3
rush change
jijizz Apr 21, 2017
95fd227
rush change
jijizz Apr 21, 2017
533c1b0
Update zhiliu-reduceFocusCost_2017-04-21-22-11.json
dzearing Apr 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions common/changes/zhiliu-reduceFocusCost_2017-04-21-22-11.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "DetailsList: when initial focus needs to be set to a row, we do so asynchronously, after page layout is completed, which reduces observed cost of the focus call from 30ms to 3ms. This should improve glass rendering performance.",
"type": "patch"
},
{
"comment": "",
"packageName": "@uifabric/utilities",
"type": "none"
},
{
"comment": "",
"packageName": "@uifabric/styling",
"type": "none"
},
{
"comment": "",
"packageName": "@uifabric/example-app-base",
"type": "none"
}
],
"email": "zhiliu@microsoft.com"
}
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/DetailsList/DetailsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ export class DetailsList extends BaseComponent<IDetailsListProps, IDetailsListSt
if (this.refs.selectionZone) {
this.refs.selectionZone.ignoreNextFocus();
}
row.focus();
this._async.setTimeout(() => row.focus(), 0);

@dzearing dzearing Mar 9, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jijizz I'm a little afraid of this change. Sometimes delaying focus can cause unexpected consequences.

Did it improve perf in your measurements?

@jijizz jijizz Apr 21, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

measurement shows focus cost reduced from 30ms to 3 ms after changing it to async.
This is help reduce our rendering time to glass.


delete this._initialFocusedIndex;
}
Expand Down