Skip to content

Dubunin/callout issues #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dubunin merged 2 commits into from
Jul 27, 2016
Merged

Dubunin/callout issues #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5288fd
#196743: removed beakWidth and class settings. Use defaults
Jul 22, 2016
4031190
TaskID 196744: updated default gapSpace to be 16
Jul 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Callout/Callout.Props.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export interface ICalloutProps extends React.Props<Callout>, IPositionProps {

/**
* The gap space between the target element and the callout.
* @default 20
* @default 16
*/
gapSpace?: number;

Expand Down
2 changes: 1 addition & 1 deletion src/components/Callout/Callout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class Callout extends React.Component<ICalloutProps, ICalloutState> {
isBeakVisible: true,
beakStyle: 'ms-Callout-beak',
beakWidth: 28,
gapSpace: 10,
gapSpace: 16,
directionalHint: DirectionalHint.rightCenter
};

Expand Down
5 changes: 1 addition & 4 deletions src/demo/pages/CalloutPage/examples/Callout.Directional.Example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ export class CalloutDirectionalExample extends React.Component<any, ICalloutDire
this.state = {
isCalloutVisible: false,
isBeakVisible: true,
directionalHint: DirectionalHint.bottomLeftEdge,
gapSpace: 10
directionalHint: DirectionalHint.bottomLeftEdge
};
}

Expand Down Expand Up @@ -81,8 +80,6 @@ export class CalloutDirectionalExample extends React.Component<any, ICalloutDire
isBeakVisible={ isBeakVisible }
onDismiss={ this._onDismiss }
directionalHint={ directionalHint }
beakStyle={ 'ms-Callout-smallbeak' }
beakWidth={ 16 }
>
<div className='ms-Callout-header'>
<p className='ms-Callout-title'>
Expand Down