DatePicker: pressing space/Enter on Previous/Next month/year arrow buttons goes 2 months at a time

[edsirko]

Bug Report

• Package version(s): 5.79.1 and 5.46.0, but not 5.39.1
• Browser and OS versions: Chrome, probably all browsers

Priorities and help requested (not applicable if asking question):

Are you willing to submit a PR to fix? (No)

Requested priority: (Normal)

Products/sites affected: (VSTS)

Describe the issue:

When keyboard navigating through the DatePicker, if you focus the up/down arrow to navigate to previous or next month (or year) and then hit spacebar or enter, you will actually navigate 2 months/years forward or back. This seems to have regressed between 5.39.1 and 5.46.0.

Actual behavior:

You will actually navigate 2 months/years forward or back.

Expected behavior:

You should navigate 1 month/year forward or back.

If applicable, please provide a codepen repro:

[KevinTCoughlin]

👋,

Thanks for the report @edsirko!

I ran git bisect and it looks like this commit may have caused the regression fd2206f

The button click handler seems to be firing twice with keyboard input hence the 2x moth or year change as reported above. We'll still want buttons for accessibility reasons, but need to circumvent that 2x behavior.

Will look into a fix unless @jordandrako wants to take it. It repros on the Fabric example page.

[jordandrako]

@KevinTCoughlin Thanks for finding the issue. Feel free to take it.