[Bug]: react-tabster - findAllFocusable method always returning ALL elements inside the target

[marcosmoura]

Library

React Components / v9 (@fluentui/react-components)

System Info

-

Are you reporting Accessibility issue?

no

Reproduction

https://codesandbox.io/

Bug Description

Actual Behavior

The findAllFocusable method needs an acceptCondition function that, when provided, will return all the elements inside the container (not only the focusable ones).

On the Tabster library, the acceptCondition function is optional, but the react-tabster wrapper has a required param. Changing it to optional, might fix the problem.

Another alternative would be changing the second parameter to a FindAllProps type, so we could decide which props to pass to Tabster.

Logs

No response

Requested priority

Normal

Products/sites affected

No response

Are you willing to submit a PR to fix?

yes

Validations

• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• The provided reproduction is a minimal reproducible example of the bug.

[ling1726]

closed by #25416

[bsunderhus]

Actually, let's keep it open. I want to investigate another possible solution. I've talked with @marcosmoura to have #25416 as a quick fix for now!

[msft-fluent-ui-bot]

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

[microsoft-github-policy-service]

Because this issue has not had activity for over 150 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.