Skip to content

fix (react-virtualizer): Ensure IO buffer gets removed, not added from calculation #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

fix (react-virtualizer): Ensure IO buffer gets removed, not added from calculation #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a4ede2
Ignore IO buffer
Mitch-At-Work Sep 29, 2025
3f089bc
Change files
Mitch-At-Work Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-contrib-react-virtualizer-388fbe2c-fba9-42e7-8369-f6484974f821.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: Ensure IO buffer is ignored in the correct direction (remove, don't add)",
"packageName": "@fluentui-contrib/react-virtualizer",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/react-virtualizer/src/components/Virtualizer/useVirtualizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ export function useVirtualizer_unstable(
// Minus from original before position
measurementPos -= overflowAmount;
// Ignore buffer size (IO offset)
measurementPos += bufferSize;
measurementPos -= bufferSize;
// Calculate how far past the window bounds we are (this will be zero if IO is within window)
const hOverflow =
latestEntry.boundingClientRect.bottom -
Expand Down