-
Notifications
You must be signed in to change notification settings - Fork 50
docs(react-virtualizer): Update virtualizer stories to use the same storybook Meta format as contrib repo #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Mitch-At-Work
merged 8 commits into
main
from
user/mifraser/add-virtualizer-to-contrib-packages
Aug 14, 2025
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
72b4197
Update virtualizer stories to use the same Meta format
Mitch-At-Work 5f26a34
Change files
Mitch-At-Work cdceb2e
Fix up storybook in v7
Mitch-At-Work 99ec085
Add some useful readme info
Mitch-At-Work 4198bf4
Ensure we have react imported for render
Mitch-At-Work e1d428e
Change files
Mitch-At-Work 907b925
Add pragma for jsx createElement
Mitch-At-Work 0d18f53
Add createElement import
Mitch-At-Work File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
change/@fluentui-contrib-react-virtualizer-2a2a41f2-f708-4042-9566-0e3f176fa187.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "fix: Remove jsx automatic runtime from render functions, import react instead", | ||
| "packageName": "@fluentui-contrib/react-virtualizer", | ||
| "email": "[email protected]", | ||
| "dependentChangeType": "patch" | ||
| } |
3 changes: 0 additions & 3 deletions
3
packages/react-virtualizer/src/components/Virtualizer/renderVirtualizer.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 1 addition & 3 deletions
4
...es/react-virtualizer/src/components/VirtualizerScrollView/renderVirtualizerScrollView.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
...alizer/src/components/VirtualizerScrollViewDynamic/renderVirtualizerScrollViewDynamic.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 9 additions & 5 deletions
14
packages/react-virtualizer/stories/VirtualizerScrollView/index.stories.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,23 @@ | ||
| import { VirtualizerScrollView } from '@fluentui/react-virtualizer'; | ||
| import descriptionMd from './VirtualizerScrollViewDescription.md'; | ||
| import accessibilityMd from './VirtualizerScrollViewAccessibility.md'; | ||
| import description from './VirtualizerScrollViewDescription.md'; | ||
| import { VirtualizerScrollView } from '../../src/VirtualizerScrollView'; | ||
| import { Meta } from '@storybook/react'; | ||
|
|
||
| export { Default } from './Default.stories'; | ||
| export { ScrollTo } from './ScrollTo.stories'; | ||
| export { SnapToAlignment } from './SnapToAlignment.stories'; | ||
|
|
||
| export default { | ||
| title: 'Preview Components/VirtualizerScrollView', | ||
| const meta: Meta<typeof VirtualizerScrollView> = { | ||
| title: 'Packages/react-virtualizer/VirtualizerScrollView', | ||
| component: VirtualizerScrollView, | ||
| parameters: { | ||
| docs: { | ||
| description: { | ||
| component: [descriptionMd, accessibilityMd].join('\n'), | ||
| accessibilityMd: accessibilityMd, | ||
| component: description, | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| export default meta; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 9 additions & 5 deletions
14
packages/react-virtualizer/stories/VirtualizerScrollViewDynamic/index.stories.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,25 @@ | ||
| import { VirtualizerScrollViewDynamic } from '@fluentui/react-virtualizer'; | ||
| import descriptionMd from './VirtualizerScrollViewDynamicDescription.md'; | ||
| import description from './VirtualizerScrollViewDynamicDescription.md'; | ||
| import accessibilityMd from './VirtualizerScrollViewDynamicAccessibility.md'; | ||
| import { Meta } from '@storybook/react'; | ||
| import { VirtualizerScrollViewDynamic } from '../../src/VirtualizerScrollViewDynamic'; | ||
|
|
||
| export { AutoMeasure } from './AutoMeasure.stories'; | ||
| export { Default } from './Default.stories'; | ||
| export { ScrollTo } from './ScrollTo.stories'; | ||
| export { ScrollLoading } from './ScrollLoading.stories'; | ||
| export { SnapToAlignment } from './SnapToAlignment.stories'; | ||
|
|
||
| export default { | ||
| title: 'Preview Components/VirtualizerScrollViewDynamic', | ||
| const meta: Meta<typeof VirtualizerScrollViewDynamic> = { | ||
| title: 'Packages/react-virtualizer/VirtualizerScrollViewDynamic', | ||
| component: VirtualizerScrollViewDynamic, | ||
| parameters: { | ||
| docs: { | ||
| description: { | ||
| component: [descriptionMd, accessibilityMd].join('\n'), | ||
| accessibilityMd: accessibilityMd, | ||
| component: description, | ||
| }, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| export default meta; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI #249