Skip to content

fix(stylelint-plugin): allow more pseudo classes #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(stylelint-plugin): allow more pseudo classes #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f15025e
fix(stylelint-plugin): allow more pseudo classes
layershifter Jul 3, 2025
099f0c9
Change files
layershifter Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-contrib-stylelint-plugin-07a48668-e1bc-4b9b-905e-994574b8380a.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "fix: allow more pseudo classes",
"packageName": "@fluentui-contrib/stylelint-plugin",
"email": "[email protected]",
"dependentChangeType": "patch"
}
4 changes: 3 additions & 1 deletion packages/stylelint-plugin/src/rules/combinator-depth/combinator-depth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import { extractAllSelectors } from '../../postcss-utils';
import { createRule } from '../../create-rule';
import { normalizeRuleName } from '../../normalize-rule-name';

const ALLOWED_PSEUDO_CLASSES = [':hover', ':active', ':focus', ':focus-within'];
Copy link
Contributor

@ling1726 ling1726 Jul 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be updated to a rule config to remove the dependency on a code release for users?


export const ruleName = normalizeRuleName('combinator-depth');

const messages = stylelint.utils.ruleMessages(ruleName, {
Expand Down Expand Up @@ -55,7 +57,7 @@ export default createRule({
if (
tokenizedSelector.length > 1 &&
tokenizedSelector[1].type === 'pseudo-class' &&
[':hover', ':active'].includes(tokenizedSelector[1].content) &&
ALLOWED_PSEUDO_CLASSES.includes(tokenizedSelector[1].content) &&
combinatorCount <= allowedDepth + 1
) {
continue;
Expand Down