Skip to content

fix(react-data-grid-react-window-grid): Export useColumnIndexContext and useRowIndexContext #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(react-data-grid-react-window-grid): Export useColumnIndexContext and useRowIndexContext #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b9673a
Export useColumnIndexContext and useRowIndexContext
Feb 11, 2025
c3d35f4
Change files
Feb 11, 2025
fcdf69a
Merge branch 'main' into usr/fengqi/exportContext
FengQiMS Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...entui-contrib-react-data-grid-react-window-grid-136754e9-7880-4a87-b3d2-50e7dee89797.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Export useColumnIndexContext and useRowIndexContext",
"packageName": "@fluentui-contrib/react-data-grid-react-window-grid",
"email": "[email protected]",
"dependentChangeType": "patch"
}
8 changes: 8 additions & 0 deletions packages/react-data-grid-react-window-grid/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,14 @@ export {
DataGridSelectionCell,
} from '@fluentui/react-components';

export {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this is a recommended approach, for most cases exporting raw Context should not be allowed as that introduces internal API leaks

based on codeowners maybe @ling1726 can provide additional POV ?

ColumnIndexContextProvider,
useColumnIndexContext,
} from './contexts/columnIndexContext';
export {
RowIndexContextProvider,
useRowIndexContext,
} from './contexts/rowIndexContext';
export type {
DataGridCellProps,
DataGridHeaderCellProps,
Expand Down